Repository navigation
fix(modules): nuclear-option players, spec.version lockstep + validate rule, Dinosaurs category - #45
Merged
Conversation
The kick, ban, and unban fields were incorrectly nested as objects with a 'command' key, but the GameTemplate CRD defines these as string fields directly. Restructured to match the CRD and the format used by other modules (minecraft-java, rust). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NsN6bnAMRM9XQtrTQ6KC7U Signed-off-by: valgulnecron <39313199+ValgulNecron@users.noreply.github.com>
…sion Add rule 10 to validate.py: GameTemplate spec.version must match the module.yaml version exactly, preventing drift like minecraft-java's (2.8.1 vs 2.9.0) that caused the wizard to display outdated versions. Also fix minecraft-java template spec.version to 2.9.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NsN6bnAMRM9XQtrTQ6KC7U Signed-off-by: valgulnecron <39313199+ValgulNecron@users.noreply.github.com>
Standardize both ark-survival-evolved and the-isle to use "Dinosaurs" (plural) for the dinosaur-themed game category. Avoids fragmenting the catalog with two spellings of the same concept; aligns with English conventions for game categories (Survival, Sandbox, etc.). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NsN6bnAMRM9XQtrTQ6KC7U Signed-off-by: valgulnecron <39313199+ValgulNecron@users.noreply.github.com>
…le.yaml The new validate.py rule requires spec.version to equal module.yaml, which the players fix bumped to 1.0.1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NsN6bnAMRM9XQtrTQ6KC7U Signed-off-by: valgulnecron <39313199+ValgulNecron@users.noreply.github.com>
Rule 10 was already taken by rule_images_pinned. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NsN6bnAMRM9XQtrTQ6KC7U Signed-off-by: valgulnecron <39313199+ValgulNecron@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Module fixes from the second live kubelab sweep. Stacked on #44 (base
fix/tmodloader-default-modpack), which already brings terraria and tmodloader into lockstep. Merge #44 first; GitHub then retargets this PR tomain.cannot unmarshal object into ... .spec.capabilities.players.ban of type string, because the template wrote kick/ban/unban as{command:}objects while the CRD fields are strings. The template now uses strings, and the module is bumped to 1.0.1.spec.versiondrifted frommodule.yaml. The wizard showsspec.version, so it displayed stale numbers (e.g. MC v2.8.1 for 2.9.0). Every template'sspec.versionnow equals itsmodule.yamlversion, and a newvalidate.pyrule 11 fails the build on drift. No module.yaml versions were bumped for this alone.Verification
*/module.yamlversion equals itstemplate.yamlspec.version.validate.py(not run locally, by the user's request).🤖 Generated with Claude Code
https://claude.ai/code/session_01NsN6bnAMRM9XQtrTQ6KC7U