Repository navigation
Conversation
- pr-labeler ran on pull_request, which gets a read-only token for PRs
from forks, so it failed on every contributor PR ("Could not add
label(s)"). Run it on pull_request_target with job-scoped write
permissions; no job checks out or runs PR code on that event.
- details-check failed the whole run when create-matrix produced an
empty matrix (PR touches no server configs). Skip the job instead.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit fb03bd8)
dgibbs64
enabled auto-merge
October 3, 2026 21:16
Member
Author
Member
Author
Member
Author
|
Closing: #4971 reaches |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cherry-pick of #4971 (already merged into
develop) ontomaster, shipped ahead of the v26.3.0 release. This PR changes CI workflow files only.Why it can't wait for the release:
pull_request_targetworkflows always run from the default branch (master), not the PR's base branch. So thepr-labelerfix from #4971 has no effect until it is onmaster. Meanwhile, PRs that includedevelop's workflow no longer run the oldpull_requestlabeler either, so fork PRs currently get no automatic labels at all.Changes (identical to #4971):
pr-labelernow runs onpull_request_target, with job-scopedcontents: read/issues: write/pull-requests: write. It never checks out or runs PR code.details-checkjob skips instead of failing the run whencreate-matrixfinds nothing to check.When
developis next merged intomasterfor the release, these files are already identical, so there's nothing to conflict.Type of change