Repository navigation
feat(background): separate execution results from report delivery - #3392
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scheduled runs can finish successfully without a report, but a model acknowledgement such as “remaining quiet” previously still appeared as a reply and could create unread work or notifications. Independent failure events also lacked an OS notification subscription. This change separates execution, report delivery and history-read state, preserving the complete original execution.
Type and Areas
Feature / bug fix. Rust Runtime and Core, session persistence, shared event contracts, Web UI, mobile web, Remote Connect, documentation.
Motivation / Impact
A conditional monitor that has no reportable change stays quiet even when its model writes a silence acknowledgement. Failures remain visible. A quiet 11:00 run cannot replace the unread identity of a 09:00 report. Older jobs/events remain readable; unknown policy strings survive round trips, unsupported descriptors stay visible, and peer policy writes negotiate
background_result_delivery_v1.The current producer is the native scheduler. Detached job completion and other producers are not silently opted into suppression.
Verification
AI-assisted implementation; focused policy, persistence, UI and compatibility coverage. Prior implementation validation passed:
Rebased onto upstream/main
96557706b. Rebase verification passed 271 tests across 16 Web/notification/next-input-suggestion integration files, Web type checking, 3 real Chrome mobile/host-stream browser tests, i18n audit and core boundaries. All 4 Core background finalization/persistence/upgrade/bot tests also passed after the rebase. No product-code conflicts remained; the one guide conflict retains both verification commands.Known full-check limitations:
check:webencounters 25 pre-existing typography violations in unchanged design-system files. Localtheme:color-audit:allpasses the color roots but discovers an unrelated pre-existing untracked MiniApp; that directory is excluded from this PR. No baselines were loosened. Real SSH/Docker, a real peer device, live IM delivery and semantic accuracy against a configured model provider were not exercised.Reviewer Notes
See the design and compatibility boundaries or 中文说明. Additional adjudication usage is recorded separately; raw task output is retained. There are no dependency or packaging changes.
Checklist