Repository navigation
feat(desktop): reorder sessions by dragging the session list - #3364
Open
czs914893385 wants to merge 1 commit into
Open
czs914893385 wants to merge 1 commit into
czs914893385 wants to merge 1 commit into
Conversation
Contributor
Author
|
Closing this for now - I want to test the interaction locally before asking for review. Sorry for the noise. |
czs914893385
force-pushed
the
feat/session-manual-reorder
branch
from
October 13, 2026 06:03
7d612c8 to
4d8f02e
Compare
Contributor
Author
|
Reopening: the lint failure in the previous revision is fixed, and the row-menu Move up / Move down items were dropped at the reporter's request, so this is now drag-only plus the Manual ordering mode. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds manual ordering to the desktop session list: a new
Manualsession-view ordering mode and drag-and-drop reordering of the session rows in the left nav.Why
The session list could only be sorted by updated / status / created / name, so sessions a user wants to keep together had no way to stay where the user put them. #3350 (merged) added the session-row menu action for copying a session; this uses the same surface, so a session row can now be copied or arranged by hand.
How
src/web-ui/src/flow_chat/utils/sessionManualOrder.ts(move inside the stored list, reconcile it against the sessions that exist, order a view from a stored list) with its own tests.manualOrdermap (workspace:<id>for one workspace group,allfor the flat "all sessions" view) beside the existingorderingpreference, persisted the same way. It is a local UI preference: corrupt or legacy values are normalized and never throw, and the persist version is not bumped.SessionsSection.tsx; every other ordering mode keeps its current behaviour.prefers-reduced-motion.Limits
Testing
pnpm run lint:web- 0 errors (the 10 remaining warnings are pre-existing in unrelated files).pnpm --dir src/web-ui run test:run- 972 files / 10760 tests pass, including the newsessionManualOrder.test.ts(17) andsessionRowManualReorder.test.tsx(17); the existingsessionRowContextMenu.test.ts(6) still passes.pnpm run build:web- green: appearance contract audit, parallel type-check + vite build, frontend revision, monaco asset verification, WebKit compatibility gate.node scripts/i18n-audit.mjs- clean.i18n
nav.sessions.viewMenu.ordering.manualadded to en-US / zh-CN / zh-TW.中文说明