Repository navigation
fix(cua): restore autonomous desktop control and simplify settings - #3363
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Computer Use tasks were blocked by a manual application-sharing picker and a separate input grant, and the desktop-control settings page exposed a large diagnostic panel. Restore agent-directed application discovery, targeting, input, verification and recovery, and return settings to the standard three-row layout.
Type and Areas
Bug/regression fix. Desktop native adapters, ComputerUse/ControlHub orchestration, built-in agent prompts, Web UI settings and control-session contracts.
Motivation / Impact
User Stop, cancellation, OS permissions, explicit tool exclusions and native capability limits remain authoritative.
Verification
AI-assisted; tested locally on macOS with real native fixtures and a real Tauri settings window using an isolated profile.
cargo test --locked -p openbitfun-core --no-default-features --features agent-runtime,git,tools-computer-use,tools-browser-web --lib computer_use_tool::tests: 51 passed; focused browser connection-hint tests: 2 passed.cargo test --locked -p openbitfun-desktop --lib computer_use: 163 passed, 9 native opt-in tests ignored.cargo build --locked -p openbitfun-desktoppassed.cargo test --locked -p openbitfun-agent-content --test prompt_catalog_contracts: 8 passed. Focused control/permission contracts: 33 passed.node scripts/test-computer-use-context.mjs: 64 passed, 1 ignored.test-macos-control-roundtrip.mjsandtest-macos-input-controls.mjs --orchestrationpassed without manual-share setup: exact input counts, Unicode/OCR verification, background opening, non-AX canvas, shortcut/scroll, Stop, and preserved observer foreground/key/stacking/cursor.check:web,build:web, focused ESLint,capabilities:check,check:repo-hygiene,check:core-boundariesandgit diff --checkpassed.node scripts/test-windows-computer-use-native.mjs --check --target x86_64-pc-windows-msvc.The broader minimal-feature Core filter also selects an existing registry test whose product-assembly expectation does not match the baseline tool plan; the owner suite passes. The Linux full-product CI suite passes all 2,573 tests, including
registry_exposes_controlhub_and_computer_use(6 tests ignored). Linux Desktop library tests pass 431 tests (4 tests ignored, including the interactive portal and AT-SPI fixtures). Windows/Linux native delivery, cold application startup, fresh OS permission/restart flows and all four remote scenarios were not exercised by this correction. Historical evidence and exact limitations are recorded indocs/architecture/computer-use-control.md.CI is complete on commit
2557c47371ece89f9ac7a4dd74bc23750c8f96d0: 11 checks pass, with 2 jobs skipped by the existing impact selector. Workflow run 38340300499 passes all three Rust/CLI OS jobs, frontend tests/builds and the aggregate validation gate. macOS Desktop library tests pass 497 tests (11 ignored). Windows compilation, CLI and independent platform contracts pass. Its Desktop test harness hits the existing Tauri #13419 pre-test loader signature (STATUS_ENTRYPOINT_NOT_FOUND); the unchanged CI policy tolerates that exact signature, so Windows Desktop library tests are not counted as executed.Reviewer Notes
Native settings inspection shows only the standard desktop-control toggle and two permission rows. No new CSS tokens or persisted-format migration. Native fixtures use disposable applications and send no real messages. Background launch requests cannot guarantee every third-party application's activation behavior.
Checklist