Repository navigation
fix(glob): Replace local rg with parallel walker - #3356
Merged
Merged
Conversation
Remove the local rg subprocess and use the parallel ignore walker so Glob behavior no longer depends on an installed rg executable. Apply ignore and hidden filtering before pattern matching, including .rgignore rules. Preserve explicit hidden roots and the product data directory exception, exact totals, and stable bounded results. Add regression coverage for filtering, result limits, and path handling. Keep remote search backends unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the local rg subprocess and use the parallel ignore walker
so Glob behavior no longer depends on an installed rg executable.
Apply ignore and hidden filtering before pattern matching, including
.rgignore rules. Preserve explicit hidden roots and the product data
directory exception, exact totals, and stable bounded results.
Add regression coverage for filtering, result limits, and path handling.
Keep remote search backends unchanged.