Repository navigation
fix(desktop): restore startup with legacy MiniApp workspace history - #3315
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix desktop startup exiting immediately when an existing current-format workspace catalog includes a MiniApp-owned directory in recent history. Accept those records and normalize only recent-project history after restoring the current workspace, preserving workspace IDs, opened/current references, and remote records. Show AppState initialization failures and the startup log path through the existing fatal-startup error reporter.
Type and Areas
Type: regression fix
Areas: workspace persistence, shared workspace startup, desktop/Tauri
Motivation / Impact
pnpm run desktop:devcompiled successfully but exited afterOpenBitFun Desktop Starting. The actual error was only inearly-startup.log: a MiniApp workspace inrecent_workspacescaused the entire catalog to be rejected. Existing catalogs now load without resetting user data or requiring manual migration.Verification
cargo test -p openbitfun-services-core --no-default-features --features workspace-persistence --lib workspace_persistence::tests(4 tests).cargo test --locked -p openbitfun-core --no-default-features --features agent-runtime,git --lib legacy_miniapp_history(1 test).cargo build -p openbitfun-desktop.pnpm run fmt:rsandgit diff --check.pnpm run desktop:devagainst the existing catalog and verified the main UI opened. All 25 workspace records and current/opened selections were retained; only the MiniApp entry was removed from recent-project history.Reviewer Notes
AI-assisted implementation; focused tests, desktop build, and local startup verification completed. Persistence schema/version and opaque workspace identities remain unchanged. Local workspace data and diagnostic logs are not included in this PR.
Checklist