Skip to content

fix(web-ui): keep device status content visible across platforms - #3288

Merged
bobleer merged 1 commit into
GCWing:mainfrom
bobleer:bob/device-status-layout
Oct 8, 2026
Merged

bobleer merged 1 commit into
GCWing:mainfrom
bobleer:bob/device-status-layout

Conversation

@bobleer

@bobleer bobleer commented Oct 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fix device-status popover content being clipped on macOS when controllers are connected, and inconsistent spacing on Windows. Let the card grow with its content, keep status and connection actions in a dedicated row, and use consistent section spacing and carousel geometry across WebKit and Chromium.

Type and Areas

Type: bug fix / UI/UX

Areas: Web UI / desktop device-status popover

Motivation / Impact

The fixed card aspect ratio constrained connected-controller rows and pushed device names and activity out of view. The popover now uses natural content height with a viewport limit and a scrollable body. Long activity and compatibility messages wrap; long device names use the shared OverflowText component and its full-text tooltip. Carousel arrows use explicit width and border-box sizing so both browser engines align them with the artwork.

Verification

  • pnpm run check:web — passed (type checking, appearance contracts, typography and theme governance).
  • pnpm --dir src/web-ui run test:run src/app/components/NavPanel/components/DeviceStatusControl.test.tsx — 16 component tests passed; the existing full-name assertion now checks the shared tooltip contract.
  • pnpm run motion:audit — completed.
  • Rendered the component's test-fixture DOM with the production styles in Chromium and WebKit. Checked connected controllers, incompatible peers and long names, plus 720×650 and 300×240 viewports. Names/actions remain reachable, the footer stays within the viewport, and arrow/artwork heights match in both engines.

Reviewer Notes

AI-assisted; focused automated and browser-rendering verification completed. Windows native WebView2 and macOS native WKWebView applications were not exercised directly. Remote workspace, Remote Connect, Peer Device Mode and Detached Dispatch were not tested end to end; peer/controller presentation uses component fixtures. This is a presentation change with no protocol or persisted-data changes.

Checklist

  • This PR is focused and does not include secrets, temporary prompts, generated scratch files, or unrelated artifacts.
  • Relevant verification is recorded above, or skipped checks are explained.
  • User-facing strings, docs, and locales are updated where applicable (no copy changes).

@bobleer
bobleer merged commit a450757 into GCWing:main Oct 8, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant