Repository navigation
fix(web-ui): keep device status content visible across platforms - #3288
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix device-status popover content being clipped on macOS when controllers are connected, and inconsistent spacing on Windows. Let the card grow with its content, keep status and connection actions in a dedicated row, and use consistent section spacing and carousel geometry across WebKit and Chromium.
Type and Areas
Type: bug fix / UI/UX
Areas: Web UI / desktop device-status popover
Motivation / Impact
The fixed card aspect ratio constrained connected-controller rows and pushed device names and activity out of view. The popover now uses natural content height with a viewport limit and a scrollable body. Long activity and compatibility messages wrap; long device names use the shared OverflowText component and its full-text tooltip. Carousel arrows use explicit width and border-box sizing so both browser engines align them with the artwork.
Verification
pnpm run check:web— passed (type checking, appearance contracts, typography and theme governance).pnpm --dir src/web-ui run test:run src/app/components/NavPanel/components/DeviceStatusControl.test.tsx— 16 component tests passed; the existing full-name assertion now checks the shared tooltip contract.pnpm run motion:audit— completed.Reviewer Notes
AI-assisted; focused automated and browser-rendering verification completed. Windows native WebView2 and macOS native WKWebView applications were not exercised directly. Remote workspace, Remote Connect, Peer Device Mode and Detached Dispatch were not tested end to end; peer/controller presentation uses component fixtures. This is a presentation change with no protocol or persisted-data changes.
Checklist