Add device mode synchronization - #56
Merged
FKKimura merged 3 commits intoAug 25, 2026
Merged
Conversation
y-vectorfield
force-pushed
the
add_device_mode_synchronization
branch
from
August 24, 2026 14:35
8135464 to
32fc36b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When running OneComp on a non-CUDA device (e.g. CPU or MPS), the device mode had to be set separately on both ModelConfig and QEPConfig.
To remove this redundancy, I added device mode synchronization between ModelConfig and QEPConfig: QEPConfig.device now defaults to None and follows ModelConfig.device when left unset. Explicitly passing QEPConfig(device=...) still takes precedence, so existing usage is unchanged.