feat(providers): add OhMyPi provider via ACP - #2
Conversation
- Run the omp CLI over ACP with approvals, resume, and model selection - Add OhMyPi icons and settings entries across web, desktop, and mobile - Document omp installation in the user guide
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 28316f8016
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Probe status via `omp models --json` instead of an ACP initialize handshake - Load models and thinking options before a thread starts; discovery errors keep the previous model list - Report the CLI version from `omp --version`
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 858f07144c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 12a532c040
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 95542bd221
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a68d58984b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
What Changed
Adds OhMyPi as a built-in provider, talking to the
ompCLI over ACP (omp acp):OhMyPiDriverand ACP adapter — availability probe without creating a session,session/newplussession/loadresume, permission requests surfaced as T3 Code approvals (auto-approved in full-access mode), streamed content/tool-call/plan events, model selection viasession/set_config_option, and per-cwd slash command capture.OhMyPiSettings(binary path, launch args, custom models) and theohMyPidriver kind with a default model slug.docs/user/install.md.Why
OhMyPi already ships an ACP endpoint, so it slots into the existing ACP provider path instead of a bespoke protocol. This lets users run OhMyPi with its local
ompcredentials from every T3 Code surface. Background text generation (commit messages, thread titles, etc.) is explicitly unsupported and fails with a clear error rather than pretending to work.UI Changes
Icon-only: adds an OhMyPi glyph to the web and mobile provider pickers and settings. No layout or motion changes.
Checklist
Model: GLM (glm-5.3-flash) · Harness: opencode