fix(web): open PR links in the thread's own checkout - #19
Merged
Merged
Conversation
- When two projects hold the same repository, `findProjectForChangeRequest` now prefers the thread's own project, so the panel attributes the PR to the thread it sits beside
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review comments; coverage includes preferred matching and fallback behavior.
Pull request overview
Updates pull-request link resolution to prefer the thread’s own project when duplicate repository checkouts exist.
Changes:
- Passes the thread’s project through exact and host-fallback lookups.
- Adds tests for preferred-project matching and fallback behavior.
File summaries
| File | Summary |
|---|---|
apps/web/src/lib/openPullRequestLink.ts |
Prefers the thread’s project when resolving links. |
apps/web/src/lib/openPullRequestLink.test.ts |
Tests preferred-project and fallback behavior. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
When a pull request link is opened beside a thread,
findProjectForChangeRequestnow accepts apreferredProjectId— the thread's own project — and prefers it when multiple projects in the same environment hold checkouts of the same repository.useOpenChangeRequestLinkresolves the thread's project viareadThreadShelland passes it through both the exact-project and host-fallback lookups. A preferred project that does not hold the repository is ignored, so the existing match rules still decide.Why
One environment can hold two checkouts of the same repository under different projects, and both match the link. The lookup could pick either one, so the right panel could treat the thread's own pull request as somebody else's branch — showing it as not-home and handing the work back to the wrong project. The thread the link is opened beside is the meaning the user intends, so its checkout wins.
Checklist