fix(server): keep assistant text contiguous across background tool updates - #16
Merged
Merged
Conversation
- ACP tool_call_update no longer closes the active assistant segment; only a new tool_call does - Extend acp-mock-agent with a mid-tool assistant text scenario and cover it in OhMyPiDriver tests
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Fryuni
enabled auto-merge
September 17, 2026 18:16
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved blocking issues were identified.
Pull request overview
Updates ACP streaming to keep assistant text contiguous across background tool progress updates.
Changes:
- Preserve assistant segments across
tool_call_updateevents. - Add mock-agent interleaving behavior.
- Add regression coverage for contiguous output.
File summaries
| File | Description |
|---|---|
apps/server/src/provider/Drivers/OhMyPiDriver.test.ts |
Verifies contiguous assistant text. |
apps/server/src/provider/acp/AcpSessionRuntime.ts |
Adjusts assistant segment boundaries. |
apps/server/scripts/acp-mock-agent.ts |
Adds interleaved tool-update simulation. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
In the ACP session runtime,
tool_call_updateevents no longer close the active assistant text segment. Only a newtool_callmarks a boundary, since updates to an existing (background) tool can arrive between chunks of a single assistant message. Added a mock-agent mode (T3_ACP_EMIT_ASSISTANT_DURING_TOOL_UPDATES) and a driver test that streams assistant chunks interleaved with background tool progress and asserts the text stays contiguous.Why
Background tools (e.g. long-running CI checks) emit progress updates while the model is still streaming its reply. Treating every update as a segment boundary split one assistant message into fragments mid-token ("
fa871" / "7" / "a68."), producing broken markdown and disjointed output for OhMyPi and other ACP-based providers. Updates to an existing tool call don't start a new speaker turn, so they shouldn't end the current message.UI Changes
Not applicable (server-side streaming behavior; no UI code changed).
Checklist