clang-tidy: resolve readability-static-definition-in-anonymous-namespace

[knoepfel]

• Code quality: Removed redundant static qualifiers from anonymous-namespace helper function definitions in the Python plugin sources, resolving the readability-static-definition-in-anonymous-namespace clang-tidy warning without changing behavior.
• Documentation: Marked the clang-tidy check as fixed and linked PR #742 in the developer fixes report.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 66c9fcfd-e245-4772-a390-046a8554ce46

📥 Commits

Reviewing files that changed from the base of the PR and between 799bb5a and ae79de9.

📒 Files selected for processing (3)

• docs/dev/clang-tidy-fixes-2026-04.md
• plugins/python/src/dyncall.cpp
• plugins/python/src/modulewrap.cpp

📜 Recent review details

🧰 Additional context used

📓 Path-based instructions (4)

**/*.{cpp,cc,cxx,h,hpp}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

**/*.{cpp,cc,cxx,h,hpp}: Use clang-format tool for all C++ code formatting (VS Code auto-formats on save); configuration defined in .clang-format with 100-character line limit and 2-space indentation
Follow clang-tidy recommendations defined in .clang-tidy

Files:

• plugins/python/src/dyncall.cpp
• plugins/python/src/modulewrap.cpp

**/*.{hpp,cpp}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{hpp,cpp}: Use .hpp for header files, .cpp for implementation, and *_test.cpp for test files in C++
Enforce 100-character line limit and 2-space indentation in C++ code via .clang-format
Use QualifierAlignment: Right (east-const) style: int const x not const int x in C++
Use PointerAlignment: Left in C++ (pointer * attached to type, not variable name)
All C++ identifiers must use lower_case naming: namespaces, classes, structs, enums, functions, variables, parameters, members, and constants
Exception to C++ naming: template parameters use CamelCase
Exception to C++ naming: macros use UPPER_CASE
Private, protected, and constant members in C++ must have a trailing underscore (_), no trailing underscore on anything else
Use enum class preferred over plain enum in C++
Use std::shared_ptr for shared ownership, std::unique_ptr for exclusive ownership, raw pointers for non-owning references only in C++
Use functors with agent-noun pattern: ModelEvaluator evaluate_model(...) in C++
Apply .clang-tidy checks for bugprone, cert, clang-analyzer, concurrency, cppcoreguidelines, misc, modernize, performance, portability, and readability as defined in the .clang-tidy configuration file
Use phlex:: namespace for core code, phlex::experimental:: for experimental features in C++

Files:

• plugins/python/src/dyncall.cpp
• plugins/python/src/modulewrap.cpp

plugins/python/**/*.cpp

📄 CodeRabbit inference engine (AGENTS.md)

plugins/python/**/*.cpp: Use std::runtime_error for C++ runtime failures; propagate Python exceptions via PyErr_SetString/PyErr_Format; return nullptr on error; call PyErr_Clear() when recovering in Python/C++ integration
Use manual Py_INCREF/Py_DECREF for reference counting and PyGILRAII RAII wrapper for GIL management in C++ code that interacts with Python
For GC-tracked Python types in C++: use Py_TPFLAGS_HAVE_GC, implement tp_traverse and tp_clear, call PyObject_GC_UnTrack before deallocation

Files:

• plugins/python/src/dyncall.cpp
• plugins/python/src/modulewrap.cpp

**/*.md

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

**/*.md: All Markdown files must follow markdownlint rule MD012: no multiple consecutive blank lines (never more than one blank line in a row)
All Markdown files must follow markdownlint rule MD022: headings must be surrounded by exactly one blank line before and after
All Markdown files must follow markdownlint rule MD031: fenced code blocks must be surrounded by exactly one blank line before and after
All Markdown files must follow markdownlint rule MD032: lists must be surrounded by exactly one blank line before and after (including after headings and code blocks)
All Markdown files must follow markdownlint rule MD034: no bare URLs (use markdown link syntax like [text](destination) instead of plain URLs)
All Markdown files must follow markdownlint rule MD036: use # headings for titles, not Bold:
All Markdown files must follow markdownlint rule MD040: always specify code block language (for example, use 'bash', 'python', '```text', etc.)

**/*.md: Do not use multiple consecutive blank lines in Markdown (MD012)
Surround Markdown headings with exactly one blank line (MD022)
Surround Markdown fenced code blocks with exactly one blank line (MD031)
Surround Markdown lists with exactly one blank line (MD032)
Do not use bare URLs in Markdown; use [text](url) syntax instead (MD034)
Use # headings in Markdown, not **Bold** for section titles (MD036)
Always specify language on fenced code blocks in Markdown (MD040)

Files:

• docs/dev/clang-tidy-fixes-2026-04.md

🔇 Additional comments (3)

plugins/python/src/dyncall.cpp (1)

52-52: LGTM!

plugins/python/src/modulewrap.cpp (1)

93-105: LGTM!

Also applies to: 243-277, 279-311, 313-349, 355-378, 380-409, 412-484, 490-500, 502-521, 523-554

docs/dev/clang-tidy-fixes-2026-04.md (1)

164-165: 📐 Maintainability & Code Quality

Keep the clang-tidy finding count aligned with PR #742. The parenthetical total should match the number of findings covered here; otherwise clarify what the count includes.

---

📝 Walkthrough

Walkthrough

Changes

Clang-tidy cleanup

Layer / File(s)	Summary
Python helper qualifier cleanup plugins/python/src/dyncall.cpp, plugins/python/src/modulewrap.cpp	Removed redundant static qualifiers from anonymous-namespace helper definitions without changing their logic or signatures.
Clang-tidy report update docs/dev/clang-tidy-fixes-2026-04.md	Marked the relevant check fixed and added the associated pull request entry.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: wlav

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly states the clang-tidy warning being resolved and matches the changes in the PR.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@           Coverage Diff           @@
##             main     #742   +/-   ##
=======================================
  Coverage   83.85%   83.85%           
=======================================
  Files         172      172           
  Lines        7198     7198           
  Branches      845      845           
=======================================
  Hits         6036     6036           
  Misses        882      882           
  Partials      280      280           

Flag	Coverage Δ
scripts	80.13% <ø> (ø)
unittests	85.73% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
plugins/python/src/dyncall.cpp	81.96% <ø> (ø)
plugins/python/src/modulewrap.cpp	74.70% <100.00%> (ø)

---

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 799bb5a...ae79de9. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[knoepfel]

@CodeRabbit review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[beojan]

Looks fine though Wim may want to take a look. Maybe the inlines should go too.

[knoepfel]

Looks fine though Wim may want to take a look. Maybe the inlines should go too.

Wim is on vacation until mid-August. So, I think we'll move forward with this for now (in an effort to resolve the clang-tidy warnings before Phlex 0.4). We can discuss the leading static keyword again once clang-tidy fails on a future PR that introduces it.