Skip to content

DO NOT MERGE: intentional formatting errors - #32

Closed
pcanal wants to merge 5 commits into
Framework-R-D:mainfrom
pcanal:formatting-errors
Closed

DO NOT MERGE: intentional formatting errors#32
pcanal wants to merge 5 commits into
Framework-R-D:mainfrom
pcanal:formatting-errors

Conversation

@pcanal

@pcanal pcanal commented Aug 25, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@pcanal

pcanal commented Aug 25, 2025

Copy link
Copy Markdown
Contributor Author

This comment content is only for form - it might be deleted later - this is to investigate fix to the clang-format comment monitor:
I went for the informational message, the current PR code issues:

cmake .
-- dot program not found; all TEST_DOT_GRAPH options will be ignored.
-- Configuring done (0.9s)
-- Generating done (0.2s)
-- Build files have been written to: /home/pcanal/phlex_working/build/phlex-standalone-cppyy

@pcanal

pcanal commented Aug 25, 2025

Copy link
Copy Markdown
Contributor Author

This comment content is only for form - it might be deleted later - this is to investigate fix to the clang-format comment monitor:
I went for the informational message, the current PR code issues:

cmake .
-- dot program not found; all TEST_DOT_GRAPH options will be ignored.
-- Configuring done (0.9s)
-- Generating done (0.2s)
-- Build files have been written to: /home/pcanal/phlex_working/build/phlex-standalone-cppyy

@phlexbot format

@pcanal

pcanal commented Aug 25, 2025

Copy link
Copy Markdown
Contributor Author

@phlexbot format

1 similar comment
@knoepfel

Copy link
Copy Markdown
Member

@phlexbot format

@pcanal

pcanal commented Aug 25, 2025

Copy link
Copy Markdown
Contributor Author

As seen here: https://github.com/Framework-R-D/phlex/actions/runs/17217542028/job/48844780022
things are 'better' but fails later on.

@pcanal

pcanal commented Aug 25, 2025

Copy link
Copy Markdown
Contributor Author

The new failures is:

Fetching the repository
  /usr/bin/git -c protocol.version=2 fetch --no-tags --prune --no-recurse-submodules --depth=1 origin +refs/heads/formatting-errors*:refs/remotes/origin/formatting-errors* +refs/tags/formatting-errors*:refs/tags/formatting-errors*
  The process '/usr/bin/git' failed with exit code 1

@knoepfel

Copy link
Copy Markdown
Member

@phlexbot format

@github-actions

Copy link
Copy Markdown
Contributor

Code-formatting changes pushed (commit dad381b)

@pcanal

pcanal commented Aug 25, 2025

Copy link
Copy Markdown
Contributor Author

This comment content is only for form - it might be deleted later - this is to investigate fix to the clang-format comment monitor:
I went for the informational message, the current PR code issues:

cmake .
-- dot program not found; all TEST_DOT_GRAPH options will be ignored.
-- Configuring done (0.9s)
-- Generating done (0.2s)
-- Build files have been written to: /home/pcanal/phlex_working/build/phlex-standalone-cppyy

@phlexbot format

@github-actions

Copy link
Copy Markdown
Contributor

Code-formatting changes pushed (commit a27eb57)

@pcanal

pcanal commented Aug 25, 2025

Copy link
Copy Markdown
Contributor Author

The code-formatting action seems to now working properly see https://github.com/Framework-R-D/phlex/actions/runs/17218217671?pr=32+%28comment%29

@pcanal pcanal closed this Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants