This repository was archived by the owner on Feb 17, 2022. It is now read-only.
Repository navigation
Conversation
Contributor
|
Awesome, lemme give this a spin and then I'll get it merged |
|
Any update on this PR ? It would be greatly appreciated ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Component playground only renders on initial render. In some situations, if Ecology is updated with props, it would not update the playground, because it was already instantiated. Adding render in componentDidUpdate fixes this.
Could also possibly explore non-ref solutions.