build: migrate effect v3 → v4 (beta.103) - #747
Open
ryanbas21 wants to merge 2 commits into
Open
Conversation
Migrate all packages from effect@^3.20 to effect@4.0.0-beta.103. Key changes: - Replace Micro with Effect throughout oidc-client and davinci-client - Migrate Either to Result in sdk-utilities and journey-client - Migrate MicroExit/exitIsFail/exitIsSuccess to Exit/Cause API - Update e2e/mock-api-v2 from @effect/platform to effect/unstable/httpapi - Bump vitest catalog to ^4.1.0 to match @effect/vitest peer requirement - Remove consolidated packages: @effect/platform, @effect/cli - Fix handleMicroExit → handleExit (renamed) - Add vi.clearAllMocks() to oidc-client afterEach (accumulated mock counts)
|
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (58)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
View your CI Pipeline Execution ↗ for commit 0f15944
💡 Dealing with memory or CPU issues? See memory and CPU details with the resource usage add-on ↗. ☁️ Nx Cloud last updated this comment at |
![nx-cloud[bot]](https://avatars.githubusercontent.com/in/80458?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Effect.sleep in v4 beta.103 hangs in Vite-bundled browser environments due to ClockRef/withFiber/clockWith indirection chain. Replace with delayMs helper using Effect.callback + plain setTimeout to match v3 Micro.sleep behavior. Also fix: - pollStatus: use Effect.runPromiseExit(effect) direct call (not pipe) - pollStatus: add Cause.squash fallback for defect errors - password-policy.rules.ts: Result.failVoid → Result.fail(undefined)
Contributor
There was a problem hiding this comment.
Nx Cloud has identified a possible root cause for your failed CI:
This CI failure appears to be related to the environment or external dependencies rather than your code changes.
No code changes were suggested for this issue.
Trigger a rerun:
🎓 Learn more about Self-Healing CI on nx.dev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the entire SDK from
effect@^3.20(v3) toeffect@4.0.0-beta.103(v4 beta).Changes by package
pnpm-workspace.yaml(catalog)effect: '4.0.0-beta.103'@effect/vitest: '4.0.0-beta.103'@effect/platform-node: '4.0.0-beta.103'@effect/platformand@effect/cli(consolidated intoeffectcore)vitestcatalog to^4.1.0packages/sdk-utilitiesmicro.utils.ts:MicroExit/exitIsFail/exitIsSuccess/causeIsDie→Exit/Cause; renamedhandleMicroExit→handleExitconfig.types/utils/effects/test:Either→Result(succeed/fail/isSuccess/isFailure)packages/journey-clientjourney.utils.ts:Either.right/left→Result.succeed/failclient.store.ts:Either.match→Result.match(onFailure/onSuccess)_tag: 'Right'/'Left'→'Success'/'Failure';.right/.left→.success/.failurepackages/oidc-client(12 files)Micro.*→Effect.*Cause.failureOption→Cause.findErrorOption(returnsOption<E>)exitIsFail(exit)→Cause.findErrorOption(exit.cause)+Option.isSomevi.clearAllMocks()inafterEachto fix accumulated mock call countspackages/davinci-client(5 files)Micro.*→Effect.*Effect.repeat({while})→Effect.gen+ manual loop (v4whilereceives schedule output type, not effect output)password-policy.rules.ts:Array.filterMapnow expectsResultcallbacks;Option.some/none()→Result.succeed/failVoidContext.Tag→Context.Servicee2e/mock-api-v2(full migration)from '@effect/platform'→from 'effect/unstable/httpapi'Context.Tag→Context.ServiceEffect.if→Effect.suspend(() => bool ? ... : ...)Option.fromNullable→Option.fromNullishOrSchema.Union(a, b)→Schema.Union([a, b])Schema.Record({key, value})→Schema.Record(key, value)Schema.Schema<T, T>→Schema.Schema<T>HttpApiMiddleware.Tag→HttpApiMiddleware.Service<Self, {provides: T}>()nxBuild→buildVerification
Summary by CodeRabbit
Bug Fixes
Improvements
Tests