Skip to content

[CLI] Expose human guide sufficiency writes (first #601 slice) - #640

Merged
abiorh-claw merged 6 commits into
mainfrom
codex/cli-guide-policy-mutations-601
Oct 22, 2026
Merged

abiorh-claw merged 6 commits into
mainfrom
codex/cli-guide-policy-mutations-601

Conversation

@Abiorh001

@Abiorh001 Abiorh001 commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Intent

Expose the two existing human guide-sufficiency POST operations in the Go CLI without treating a diagnostic or warning acknowledgement as compiled setup, policy approval, or activation.

Scope

  • Add project guide sufficiency create and acknowledge-warnings under the existing inspection namespace.
  • Keep current Project Manager authority, draft/latest-source lineage, warning eligibility, duplicates, and exact replay with the backend. Preserve caller-owned UUID keys, bounded JSON, bearer redaction, terminal-safe text, and uncertain-write handling.
  • Update the CLI README, roadmap capability claims, and WS-CLI-001-38.
  • No backend, shared transport, artifact-policy command, approval, activation, CI, or dependency change.

Evidence

  • Current clean head d57daa86e82e68a0ba4eedf6eeb104224be85898 merges reviewed prior head d45f7826f5478a7d6a359a50ff972cd5728fddb7 with main c2fe5e575bd3ec69ab20c0eb103f2304545dbccd. The sufficiency feature's Go source is unchanged from the reviewed candidate; main's other merged CLI features are retained.
  • Built-binary HTTP: 20 passed again after the main merge, including canonical conflict forwarding, malformed/mismatched write success, invalid input, exact request bytes, and no automatic replay.
  • Isolated real PostgreSQL/public-API probe: both tests passed in 106.65 seconds on 942e293e and 172.19 seconds on d45f7826, each with database/role cleanup. On current d57daa86, both local tests stopped before API assertions at the unchanged 90-second Uvicorn readiness bound (empty startup logs); the isolated runner again reports cleanup_complete=true. That local current-head attempt was not a pass; the subsequent hosted CLI public API/PostgreSQL job passed on this exact head. The earlier passing probe used Alembic 0056. The tests cover exact replay, same-key changed-body conflict, revoked replay, and owner-produced setup reaching manual artifact-policy POST/PATCH. This proves route feasibility, not that CLI commands for those two writes exist.
  • Three hosted blockers from the previous head were test expectations/formatting: raw PostgreSQL UUID compared with UUID, canonical manual_admin_derivation asserted on manual create/PATCH, and both new Python tests Ruff-formatted. Ruff format/check and py_compile pass. Focused internal test-delta replay closed PASS on 942e293e with no assertion loss; focused docs/architecture reconciliation reviews closed PASS at exact merge heads d45f7826f and d57daa86e.
  • Prior unchanged Go source passed go test ./..., go vet ./..., and go mod verify. On current d57daa86e, the combined Go build/tests, 20 focused HTTP cases, Markdown links, stale wording, Commitrail, module integrity, and branch diff checks passed. Full hosted Backend CI passed on this exact head, including the CLI public API/PostgreSQL job and full-suite evidence validation: https://github.com/Flow-Research/workstream/actions/runs/39761633209.

Boundaries and review focus

This PR implements only two of four operations in #601. Manual artifact-policy POST/PATCH are now demonstrated through the public API after owner-produced setup, but their CLI commands remain unimplemented. Existing backend test backend/tests/test_projects.py:4878 proves compiled-warning acknowledgement refusal; this PR separately proves CLI conflict propagation, not a new real-API compiled-warning run. Review response integrity, project/guide/snapshot binding, exact replay, and diagnostic versus authoritative evidence. Marked ready for review after current-head CI passed and the head was confirmed unchanged, conflict-free and without unresolved review threads. No merge performed.

Refs #601; does not close it.

@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 33 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: fe66f40e-4a5b-4f1c-91f5-deb0990e51e4
📥 Commits

Reviewing files that changed from the base of the PR and between c2fe5e5 and d57daa8.

📒 Files selected for processing: 9
  • .commitrail/initiatives/WS-CLI-001/OVERVIEW.md
  • .commitrail/initiatives/WS-CLI-001/WS-CLI-001-38.md
  • cli/README.md
  • cli/internal/api/guide_sufficiency_mutations.go
  • cli/internal/command/guide_inspection.go
  • cli/internal/command/guide_sufficiency_mutations.go
  • cli/tests/integration/test_guide_sufficiency_mutations_http.py
  • cli/tests/integration/test_guide_sufficiency_mutations_public_api.py
  • docs/roadmap_status.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Abiorh001

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@Abiorh001
Abiorh001 marked this pull request as ready for review October 22, 2026 11:27
@Abiorh001

Copy link
Copy Markdown
Collaborator Author

Verification update: full Backend CI passed at d57daa8, including the CLI public API/PostgreSQL job and full-suite evidence validation: https://github.com/Flow-Research/workstream/actions/runs/39761633209 . Marked ready for review after confirming the unchanged head, no merge conflicts and no unresolved review threads. No merge performed.

@abiorh-claw
abiorh-claw merged commit 8f65c9d into main Oct 22, 2026
68 checks passed
@abiorh-claw
abiorh-claw deleted the codex/cli-guide-policy-mutations-601 branch October 22, 2026 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants