Repository navigation
[CLI] Expose human guide sufficiency writes (first #601 slice) - #640
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 33 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
|
|
Verification update: full Backend CI passed at d57daa8, including the CLI public API/PostgreSQL job and full-suite evidence validation: https://github.com/Flow-Research/workstream/actions/runs/39761633209 . Marked ready for review after confirming the unchanged head, no merge conflicts and no unresolved review threads. No merge performed. |
Intent
Expose the two existing human guide-sufficiency POST operations in the Go CLI without treating a diagnostic or warning acknowledgement as compiled setup, policy approval, or activation.
Scope
project guide sufficiency createandacknowledge-warningsunder the existing inspection namespace.Evidence
d57daa86e82e68a0ba4eedf6eeb104224be85898merges reviewed prior headd45f7826f5478a7d6a359a50ff972cd5728fddb7with mainc2fe5e575bd3ec69ab20c0eb103f2304545dbccd. The sufficiency feature's Go source is unchanged from the reviewed candidate; main's other merged CLI features are retained.942e293eand 172.19 seconds ond45f7826, each with database/role cleanup. On currentd57daa86, both local tests stopped before API assertions at the unchanged 90-second Uvicorn readiness bound (empty startup logs); the isolated runner again reportscleanup_complete=true. That local current-head attempt was not a pass; the subsequent hosted CLI public API/PostgreSQL job passed on this exact head. The earlier passing probe used Alembic 0056. The tests cover exact replay, same-key changed-body conflict, revoked replay, and owner-produced setup reaching manual artifact-policy POST/PATCH. This proves route feasibility, not that CLI commands for those two writes exist.manual_admin_derivationasserted on manual create/PATCH, and both new Python tests Ruff-formatted. Ruff format/check andpy_compilepass. Focused internal test-delta replay closed PASS on942e293ewith no assertion loss; focused docs/architecture reconciliation reviews closed PASS at exact merge headsd45f7826fandd57daa86e.go test ./...,go vet ./..., andgo mod verify. On currentd57daa86e, the combined Go build/tests, 20 focused HTTP cases, Markdown links, stale wording, Commitrail, module integrity, and branch diff checks passed. Full hosted Backend CI passed on this exact head, including the CLI public API/PostgreSQL job and full-suite evidence validation: https://github.com/Flow-Research/workstream/actions/runs/39761633209.Boundaries and review focus
This PR implements only two of four operations in #601. Manual artifact-policy POST/PATCH are now demonstrated through the public API after owner-produced setup, but their CLI commands remain unimplemented. Existing backend test
backend/tests/test_projects.py:4878proves compiled-warning acknowledgement refusal; this PR separately proves CLI conflict propagation, not a new real-API compiled-warning run. Review response integrity, project/guide/snapshot binding, exact replay, and diagnostic versus authoritative evidence. Marked ready for review after current-head CI passed and the head was confirmed unchanged, conflict-free and without unresolved review threads. No merge performed.Refs #601; does not close it.