Incorrect DEFAULT_MAX_INLINE_BLOB_SIZE value

[Noremos]

In the Firebird, the MAX_INLINE_BLOB_SIZE is MAX_USHORT witch is equals to 65535 (see https://github.com/FirebirdSQL/firebird/blob/master/src/remote/remote.h#L107C43-L107C58).

But Jaybird sets the value to 65536:

jaybird/src/main/org/firebirdsql/jaybird/props/PropertyConstants.java

Line 61 in c097281

public static final int DEFAULT_MAX_INLINE_BLOB_SIZE = 64 * 1024;

Firebird handles these cases, but the Debug build has an annoying assert violation. It would be nice to fix it.
I'll create a pull request for this.

[mrotteveel]

Thanks. I guess I made an off by one error there.

Firebird handles these cases, but the Debug build has an annoying assert violation. It would be nice to fix it.

I don't think that should produce an assert in Firebird, because it's user input out of control of Firebird itself. It should enforce its own minimum and maximum values, and maybe post a warning in the status vector.

[Noremos]

Thanks. I guess I made an off by one error there.

Firebird handles these cases, but the Debug build has an annoying assert violation. It would be nice to fix it.

I don't think that should produce an assert in Firebird, because it's user input out of control of Firebird itself. It should enforce its own minimum and maximum values, and maybe post a warning in the status vector.

There are checks for min and max values, but without any warning. I'll look into this issue. Thanks for the advice.

[mrotteveel]

Thanks for the fix :)

[mrotteveel]

A workaround for this is setting the system property org.firebirdsql.jdbc.defaultMaxInlineBlobSize with value 65535 (see also Default inline blob property values).