Wrong SQLSTATE in case of table alias conflict

[EPluribusUnum]

Hi *!

SELECT *
FROM rdb$database a
JOIN rdb$database b ON a.rdb$relation_id = b.rdb$relation_id
JOIN rdb$database b ON a.rdb$relation_id = b.rdb$relation_id

Undefined name.
Dynamic SQL Error.
SQL error code = -204.
alias B conflicts with an alias in the same statement.

SQLCODE: -204
SQLSTATE: 08001
GDSCODE: 335544569

Because of this org.firebirdsql.jaybird.xca.FatalErrorHelper.isFatal() returns true for this error and closes the Connection.
(FATAL_SQL_STATE_CLASSES / SQLSTATE_CLASS_CONNECTION_ERROR)

FB 3.x, 4.x and 5.x are all affected.

[mrotteveel]

I'll see if I can correct this, and do a more thorough check if there are other errors incorrectly associated with SQLstate class 08.

[EPluribusUnum]

@mrotteveel, the connection close for "08" is a JDBC requirement? If not, it would be great to have a System property to turn off this feature.

[AlexPeshkoff]

On 9/12/25 14:57, EPluribusUnum wrote: *EPluribusUnum* left a comment (FirebirdSQL/firebird#8739) <#8739 (comment)> @mrotteveel <https://github.com/mrotteveel>, the connection close for "08" is a JDBC requirement? If not, it would be great to have a System property to turn off this feature.

Looks like it's engine code: SQL> SELECT * CON> FROM rdb$database a CON> JOIN rdb$database b ON a.rdb$relation_id = b.rdb$relation_id CON> JOIN rdb$database b ON a.rdb$relation_id = b.rdb$relation_id; Statement failed, SQLSTATE = 08001 <=============================================== Dynamic SQL Error -SQL error code = -204 -alias "B" conflicts with an alias in the same statement If it's really wrong that should better be fixed in engine.

[mrotteveel]

@AlexPeshkoff I am fixing it in the engine

@EPluribusUnum The detection in Jaybird is to determine which connections are for all intents and purposes unusable or in an inconsistent state after an error and thus need to be closed.

[EPluribusUnum]

@mrotteveel , it's about responsibility, and state consistency. An upper pool manager opened the connection, it should be closed by the pool manager also.

[mrotteveel]

@EPluribusUnum For these errors, the connections is (or should be) for all intents and purposes unusable. However, I think that is a discussion that doesn't belong in this ticket.