1.21.1/dev - #61
Merged
Merged
1.21.1/dev#61
Conversation
Marking rank data dirty instead of player data, oops
"name" and "power" are now rejected in addition to "condition"
- rank creation during load no longer uses setCondition() but injects the condition directly, avoiding side effects which are unwanted during load - moved readPermssions and writePermissions into RankImpl, the only class which uses them - on read, non-primitive json permission nodes are now warned about and not added to the permissions map at all - on write, unexpected permission node classes are warned about and not added to the json object at all
Also tightened up caller check in FTBRanksAPI#setup
MichaelHillcox
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.