feat(comms): log one message to several leads — iris comms log <ids..> (#186156) - #85
Merged
Merged
Conversation
….>` (#186156) `comms log` took exactly one lead, so an email to three people was three unrelated rows, logged by hand, with nothing saying they were one message. iris comms log 29019 29016 29021 --channel apple_mail --subject "…" -m "…" Every lead gets its own copy, all with ONE shared message group id, ONE timestamp and the full recipient list; `comms list` shows "also sent to: …" on each lead's timeline. --group reuses a group to add someone later or re-run safely (idempotent per lead on the server). --cc records non-lead addresses without logging to them. A lead name that does not resolve logs NOTHING, rather than logging to some recipients and quietly skipping one. Read-back, not trust: a copy only counts as logged if the row that comes back is on THAT lead. Before the server fix, recipients 2..N got a 200 carrying the first lead's row and the CLI said "Logged" — so checkLogged() treats a wrong-lead 2xx as a failure (exit 1). Mutation-checked: trusting any 2xx fails exactly that test. Pure half in comms-log-group.ts, 8 tests. Full src/cli/cmd suite 1545/0. Server side: fl-api LeadComm::logManual (same issue number). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K9LZmfMCptv6tUqxryDrTx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iris comms lognow takes one or more leads: one copy each, linked by a shared message group id, with the full recipient list on every copy and "also sent to" on each timeline.--groupre-runs idempotently;--ccrecords non-lead addresses. A copy only counts as logged if the returned row is on that lead — a wrong-lead 2xx is a failure (the old silent-drop). Needs the fl-apiLeadComm::logManualfix deployed first.Tests: comms-log-group 8/8 (mutation-checked); src/cli/cmd 1545/0.
🤖 Generated with Claude Code