Ask Concierge screen - #100552
Draft
rushatgabhane wants to merge 2 commits into
Draft
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx bun ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Builds the Ask Concierge screen from the Figma design in the main Concierge DM, behind the
conciergeRespondInThreadbeta: a centered welcome empty state, a chat history toggle that expands and collapses the earlier conversation, quick actions under the composer, and aYour personal AI assistantsubtitle plus aNew chatbutton in question threads. Everything outside the beta is unchanged.Fixed Issues
For #94503
PROPOSAL:
Tests
conciergeRespondInThreadbeta and open the Concierge chat from the Inbox.Conciergewith the subtitleYour personal AI assistant, and the composer placeholder isHow much did I spend last month?.Ask me anything!, the supporting copy, and the four quick actions under the composer.Analyze spendand verify its prompt is written into the composer and the composer is focused.View chat history, verify the earlier conversation appears withAsk a new questionabove the composer, then pressHide chat historyand verify it collapses again.New chatbutton that returns you to the Concierge chat in its welcome state.main.Offline tests
Same as tests. The welcome state, the history toggle and the quick actions all read data already in Onyx, so they render offline; only expanding history beyond the cached page needs a connection.
QA Steps
conciergeRespondInThreadbeta and open the Concierge chat.View chat history/Hide chat historytoggle.New chatand returns you to the Concierge chat.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari