Move pre-selected custom list to top of list in the NetSuite custom list picker - #100511
Draft
marufsharifi wants to merge 2 commits into
Draft
Move pre-selected custom list to top of list in the NetSuite custom list picker#100511marufsharifi wants to merge 2 commits into
marufsharifi wants to merge 2 commits into
Conversation
…d improve search filtering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
When opening the NetSuite custom-list picker, the currently-selected list was shown
in its natural position, so on a long list it could sit below the fold. This pins
the pre-selected list to the top on open (and keeps it pinned while searching),
matching the "move pre-selected items to top" pattern used across the app.
Fixed Issues
$
PROPOSAL:
Tests
Precondition: A workspace on a Control plan connected to NetSuite, where the NetSuite account has 12 or more custom lists synced. You'll also need one custom field already configured so a custom list is pre-selected (or you'll select one and reopen the picker).
NetSuiteCustomListSelectorPage).Offline tests
Same as tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-09-08.at.6.32.09.PM.mov
Android: mWeb Chrome
Screen.Recording.2026-09-08.at.6.35.39.PM.mov
iOS: Native
Screen.Recording.2026-09-08.at.6.44.19.PM.mov
iOS: mWeb Safari
Screen.Recording.2026-09-08.at.6.45.49.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2026-09-08.at.6.19.53.PM.mov