Skip to content

Move pre-selected custom list to top of list in the NetSuite custom list picker - #100511

Draft
marufsharifi wants to merge 2 commits into
Expensify:mainfrom
marufsharifi:fix/netsuite-custom-list-selected-order
Draft

Move pre-selected custom list to top of list in the NetSuite custom list picker#100511
marufsharifi wants to merge 2 commits into
Expensify:mainfrom
marufsharifi:fix/netsuite-custom-list-selected-order

Conversation

@marufsharifi

@marufsharifi marufsharifi commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

When opening the NetSuite custom-list picker, the currently-selected list was shown
in its natural position, so on a long list it could sit below the fold. This pins
the pre-selected list to the top on open (and keeps it pinned while searching),
matching the "move pre-selected items to top" pattern used across the app.

Fixed Issues

$
PROPOSAL:

Tests

Precondition: A workspace on a Control plan connected to NetSuite, where the NetSuite account has 12 or more custom lists synced. You'll also need one custom field already configured so a custom list is pre-selected (or you'll select one and reopen the picker).

  1. Sign in and open the workspace connected to NetSuite.
  2. Go to Workspace settings → Accounting.
  3. On the NetSuite connection, open Import → Custom fields (custom segments/lists).
  4. Tap Add and choose the Custom list type, then open the "List name" selector (the NetSuiteCustomListSelectorPage).
  5. Because there are 12+ lists, a search box appears at the top. Confirm the list of custom lists renders.
  6. Pin on open: With no list selected yet, the order is the default (server) order. Now set a custom list, leave the selector, and reopen it (or open the picker for a field that already has a list selected).
  7. Verify: the pre-selected custom list is pinned at the very top of the list (above all others), with its row highlighted/checked — even if alphabetically/naturally it would sit lower and be below the fold.
  8. No jump on select: tap a different custom list in the list.
  9. Verify: the tapped row is selected in place and the list does not jump or reorder while the picker is open (the previously pinned list stays where it is).
  10. Pin held during search: type part of the pre-selected list's name in the search box.
  11. Verify: the pre-selected list stays pinned at the top of the filtered results (it doesn't drop into its natural position among the matches).
  12. Clear the search and confirm the pre-selected list is still pinned at the top.
  13. Below-threshold check: repeat on a NetSuite workspace/account with fewer than 12 custom lists.
  14. Verify: no search box, and the list stays in its normal (unpinned) order — the selected list is not floated to the top.
  • Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen.Recording.2026-09-08.at.6.32.09.PM.mov
Android: mWeb Chrome
Screen.Recording.2026-09-08.at.6.35.39.PM.mov
iOS: Native
Screen.Recording.2026-09-08.at.6.44.19.PM.mov
iOS: mWeb Safari
Screen.Recording.2026-09-08.at.6.45.49.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2026-09-08.at.6.19.53.PM.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant