Conversation
TRusselo
marked this pull request as draft
September 21, 2026 01:16
ScummVM fetches its engine data over the network during game load: LibretroRemoteEngineData::fetch() sits in the engine search path and calls emscripten_wget_data(), which is synchronous. Built without ASYNCIFY that blocks the main thread and the load never completes. Assisted-by: Claude:claude-opus-5
TRusselo
force-pushed
the
add-scummvm-needsasync
branch
from
September 24, 2026 03:44
f21b106 to
7994a5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ScummVM fetches its engine data over the network during game load.
LibretroRemoteEngineData::fetch()is registered in the engine search path and callsemscripten_wget_data(), which is synchronous:emscripten_wget_data(url.c_str(), &buffer, &numBytes, &error);Engines pull
fonts.dat,toon.datand similar from there whileretro_load_game()is running, so without ASYNCIFY that call blocks the main thread and the load never completes.Same shape as
bluemsxin ad2ca2a — a core doing synchronous I/O during load.One line, no behaviour change for any other core.
AI assistance: written with Claude, reviewed and tested by me before opening.