Repository navigation
IMXRT-46: docker: ignore the installer image marker too - #1
Open
vladimirkhusainov-emcraft wants to merge 1 commit into
Open
vladimirkhusainov-emcraft wants to merge 1 commit into
vladimirkhusainov-emcraft wants to merge 1 commit into
Conversation
run.sh writes .image-built-at-installer for the WITH_INSTALLER=1 image, which the .gitignore entry did not match; .dockerignore already uses the glob.
vladimirkhusainov-emcraft
requested review from
sposelenov-emcraft and
vdskvortsov
October 6, 2026 12:20
Contributor
Author
|
@sposelenov-emcraft @vdskvortsov Ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docker/.gitignoreignores.image-built-at*, so the-installermarker thatrun.shwrites forWITH_INSTALLER=1is ignored too..dockerignorealready uses the same glob.Companion: EmcraftSystems/scripts#2. Design and test record: EmcraftSystems/imxrt_linux#60.