Repository navigation
fix(http): read response cookies when Headers has no getSetCookie - #8772
Merged
tim-smart merged 1 commit intoOct 5, 2026
Merged
Conversation
React Native's Headers implementation does not provide getSetCookie, so reading HttpClientResponse.cookies threw a TypeError there. Treat a missing getSetCookie as no Set-Cookie headers. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 8fe8fb1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
juliusmarminge
added a commit
to pingdotgg/t3code
that referenced
this pull request
Oct 5, 2026
RequestHooks and the ConnectionHooks onPing/onPong/onPingTimeout callbacks have had no callers since the client connection rewrite (#2978). The patch now carries only MCP session DELETE (upstream: Effect-TS/effect#8773), the getSetCookie guard (Effect-TS/effect#8772) and the missed-pong tolerance (Effect-TS/effect#8774). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
Merged
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
HttpClientResponse.cookiesfor a fetch response callsthis.source.headers.getSetCookie(). React Native'sHeadersdoes not implementgetSetCookie, so reading.cookiesthere throwsTypeError: this.source.headers.getSetCookie is not a function. It shows up when code inspects a rejected response, for example while mapping a non-2xx status to an error.Fix
Treat a missing
getSetCookieas noSet-Cookieheaders:getSetCookie?.() ?? []. React Native never exposesSet-Cookieto JavaScript, so an empty list is accurate there. Environments that implement it are unchanged.Testing
packages/effect/test/http/HttpClient.test.ts: aResponsewhoseheaders.getSetCookieisundefinedyields empty cookies. It fails onmainwith theTypeErrorand passes with the fix.oxlintanddprint checkon the changed files,tsc --noEmitforpackages/effect.We have carried this as a local patch in T3 Code since our mobile app hit it.