Fix atom writes dropped by batch commit listeners - #8556
Merged
tim-smart merged 6 commits intoSep 27, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 97370aa The changes in this PR will be included in the next version bump. This PR includes changesets to release 31 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An
Atom.fnwrite made by a subscription callback duringAtomRegistry.batchcommit can be lost. The callback queues a rebuild after the batch has finished its rebuild pass, and cleanup discards that pending work. In #8546, the source stays at1instead of reaching2.Keep draining rebuilds queued during commit until none remain, restore the enclosing phase when a nested batch returns, and remove a pending notification before invoking its listeners so they can queue it again. This preserves grouped dependent updates and delivers successive writes made by listeners.
Closes EFF-1602
Closes #8546