Repository navigation
Add native socket formatting helpers to NetAddress - #8325
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 4b25e76 The changes in this PR will be included in the next version bump. This PR includes changesets to release 31 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
fubhy
commented
Sep 20, 2026
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
fubhy
commented
Sep 20, 2026
Merged
arrudaricardo
pushed a commit
to arrudaricardo/effect
that referenced
this pull request
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native socket adapters need platform-specific IPv6 zone formatting. Add
NetAddress.formatNativeHost(address, scopeIds, platform?)andNetAddress.formatMulticastInterface(networkInterface, scopeIds, platform?), accepting the map returned byscopeIdsFromInterfacesdirectly.The optional third argument accepts a platform string; omitting it uses non-Windows behavior. Windows retains numeric scope IDs; other platforms use the first matching interface name with numeric fallback. IPv4 formatting and zero-scope behavior are preserved. Both helpers are pure and leave platform detection and interface discovery to callers. The supplied helpers were not present on
main, so there are no existing call sites to migrate.Validation: all 44 NetAddress tests pass;
pnpm check,pnpm lint-fix,pnpm lint, andpnpm jsdocs --checkpass. Includes a patch changeset.