Repository navigation
Fix cluster request resets stranded by in-memory deduplication - #8317
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: dfa11c2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 31 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
Merged
arrudaricardo
pushed a commit
to arrudaricardo/effect
that referenced
this pull request
Sep 23, 2026
This was referenced Sep 24, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release targeted storage claims when a reset request is suppressed by completed-request deduplication, including the exit-publication window before active-request cleanup. This lets the receiving runner recover resets initiated locally or through shared storage on another runner without waiting for the ten-minute claim timeout.
Active requests, including streams that have emitted chunks, retain their claims. A separate exit flag distinguishes completion from chunk publication;
notifyLocalkeeps its existingexcludeRepliessemantics. Targeted-release failures are contained so capped-address claims from the same batch still get released.MessageStorage.resetRequestsclears only selected request claims, preserving replies, processed state, and unrelated requests. SQL, memory, and noop implementations are included. Custom drivers must implement this new required member of the exported storage interfaces; the changeset documents that compatibility impact despite the rc patch classification.Coverage and validation
EFFECT_INTEGRATION_TESTS=1). Storage contracts cover empty input, targeted release, and reply/processed-state preservation.nix develop -c pnpm lint-fix,nix develop -c pnpm check, andgit diff --checkpassed.The deterministic Sharding tests use memory storage. Unlike SQL storage, it does not exclude requests with unacknowledged chunk replies, and it does not model PostgreSQL locking or concurrent transactions. The remote-reset case uses two adapters over shared persistence, not two processes. These limits are documented in the memory driver.
Independent re-review and the reporter's Bun/PostgreSQL workload (300 workflows, 20 concurrent) remain required before acceptance. That workload has not been run against this revision.
Closes EFF-1426
Closes #8312