Repository navigation
fix(sql-pg): support regclass binary values - #8309
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: a295f98 The changes in this PR will be included in the next version bump. This PR includes changesets to release 31 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
tim-smart
enabled auto-merge (squash)
September 19, 2026 22:19
Merged
tristanz
added a commit
to continual-ai/company-os
that referenced
this pull request
Sep 22, 2026
Effect 4.0.0-rc.117 includes the merged savepoint cleanup ([#8308](Effect-TS/effect#8308)) and regclass codecs ([#8309](Effect-TS/effect#8309)). Upgrade the aligned Effect packages and remove the obsolete pnpm patch, patch documentation, and custom regclass registration. Keep the timestamp precision codec. Verified both fixes in the published packages; all upgraded packages satisfy the 24-hour minimum release age. Validation: `pnpm check`, `pnpm test` (499 tests), `pnpm build`, and `git diff --check` pass. Existing savepoint, regclass, migration, and reset regressions pass without the workarounds. No new tests. <!-- codesmith:footer --> --- <a href="https://app.blacksmith.sh/continual-ai/codesmith/company-os/pr/7?ref=codesmith_pr_footer"><picture><source media="(prefers-color-scheme: dark)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-dark-v2.svg"><source media="(prefers-color-scheme: light)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-light-v2.svg"><img alt="View with [code]smith" src="https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-dark-v2.svg"></picture></a> <a href="https://backend.blacksmith.sh/track/enable-autofix?expires=1792684133&installation_model_id=20102&pr_number=7&ref=codesmith_pr_footer&repository=continual-ai%2Fcompany-os&return_to=https%3A%2F%2Fgithub.com%2Fcontinual-ai%2Fcompany-os%2Fpull%2F7&signature=8b438d2067d8d1548fa14ef5b02ca43acbfe47ec4d57c2f978c0be2b5c9a9e97"><picture><source media="(prefers-color-scheme: dark)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-light.svg"><img alt="Autofix with [code]smith" src="https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-dark.svg"></picture></a> <sup>Need help on this PR? Tag <code>@codesmith-bot</code> with what you need. Autofix is disabled.</sup> <!-- codesmith:autofix:disabled --> <!-- /codesmith:footer -->
arrudaricardo
pushed a commit
to arrudaricardo/effect
that referenced
this pull request
Sep 23, 2026
Co-authored-by: Tim Smart <hello@timsmart.co>
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PostgreSQL driver treats unregistered
regclassresults as UTF-8, producing strings or decoding errors. This also affects the migration runner's table-existence query.Reuse the unsigned OID codec for
regclassand registerregclass[]with the existing array machinery. Values decode as numeric OIDs; callers wanting relation names can cast totextin SQL, for exampleSELECT 'public.orders'::regclass::text.Validation: the scalar regression and existing array cases fail before the fix and pass afterward. All 119 codec and migrator tests pass, along with
pnpm lint-fixandpnpm check. A temporary PostgreSQL probe verified scalar/array results and repeated migration runs.Closes EFF-1424