Expose HttpApi.ParseOptions for schema decoding and encoding - #8269
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: b1bd7ad The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
Drop the wire-presence tracking (WeakMap, hasId, prototype input) and the second decode branch in Sse.decodeSchema. transformEvent now omits an absent id, and the data-mode event schema reuses Sse.EventEncoded.fields, so one decode path serves strict and default parse options. Fold repeated codec construction behind local helpers in HttpApiBuilder and HttpApiClient, and trim the ParseOptions docs and changeset.
tim-smart
enabled auto-merge (squash)
September 17, 2026 08:10
arrudaricardo
pushed a commit
to arrudaricardo/effect
that referenced
this pull request
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
HttpApi.ParseOptionsfor API, group, and endpoint annotations. Options follow API → group → endpoint precedence, with whole-value replacement and Schema defaults when unset.Forward options through server request decoders and response encoders, including multipart, WithHeaders, and SSE. Generated clients use the same options for request encoding, response decoding, and
urlBuilder.Includes a patch changeset for
effectand the preceding tests-first commit with 29 regression cases.Validation
nix develop -c pnpm check: passes.nix develop -c pnpm lint: passes.nix develop -c pnpm jsdocs --check: reports two existing documentation errors inpackages/effect/src/unstable/ai/McpSchema.ts; HttpApi documentation passes.Closes #8266
Closes #8268
Closes EFF-1393