Fix multipart hang when request body fails during an active file - #8206
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 39c0113 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
Name the MultipartError normalisation once, map upstream errors where IE is in scope so FileImpl stays a plain holder, flatten the file pull loop guards, and share the failing-body fixture across the regression tests.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a request body fails during an active multipart file, consuming that file hangs until a timeout. The file pull loop now returns the recorded failure after delivering buffered bytes, while preserving normal file completion.
File content and persistence preserve existing
MultipartErrorvalues and their original cause chains, wrapping other errors asInternalError. Includes shared and Bun regressions for the hang,contentEffectfailure coverage, a persisted cause-chain regression, and an Effect patch changeset.Validation passed:
nix develop -c pnpm test --run packages/effect/test/unstable/http/Multipart.test.ts(19 tests)nix develop -c bun run --bun test --run packages/platform/bun/test/BunMultipart.test.ts packages/platform/bun/test/BunStream.test.ts(2 tests, Bun 1.3.13)nix develop -c pnpm lint-fixnix develop -c pnpm checknix develop -c pnpm exec changeset status --since=51d4a2f08a5c7691dc876415bc9fc0ecf467e153(merge base; patch detected)Closes EFF-1359
Closes #8203