Repository navigation
Fix zero maxBytes handling in NodeStream - #7233
Merged
tim-smart merged 2 commits intoAug 13, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: f00e098 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull request overview
Fixes a bug in @effect/platform-node-shared where maxBytes: 0 was treated as “no limit” in NodeStream consumers due to truthiness checks, and adds regression coverage to prevent reintroduction.
Changes:
- Replace truthiness checks with explicit
undefinedchecks formaxBytesinNodeStream.toStringandNodeStream.toArrayBuffer. - Add regression tests ensuring
maxBytes: 0is enforced for both string and binary stream consumption. - Add a changeset for a patch release noting the zero-byte limit enforcement.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/platform/node-shared/src/NodeStream.ts | Fixes maxBytes: 0 handling by using !== undefined checks in both consumers. |
| packages/platform/node-shared/test/NodeStream.test.ts | Adds regression tests asserting zero-byte limits fail as expected. |
| .changeset/fix-zero-max-bytes.md | Declares a patch release entry for the behavior fix. |
Suppressed comments (1)
packages/platform/node-shared/src/NodeStream.ts:300
- When
maxBytesis exceeded, the stream is not destroyed. SinceEffect.callbackcleanup runs only on interruption, failing viaresume(Effect.fail(...))can leave the stream active and continue pushing chunks into memory even though the effect has already failed. Destroy the stream before resuming the failure, consistent with the"error"handler above.
if (maxBytesNumber !== undefined && bytes > maxBytesNumber) {
resume(Effect.fail(onError(new Error("maxBytes exceeded")) as E))
}
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
tim-smart
approved these changes
Aug 13, 2026
Merged
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Description
NodeStream.toStringandNodeStream.toArrayBufferacceptedmaxBytes: 0, but truthiness checks treated the value as if no limit had been supplied. Both functions therefore consumed non-empty streams even though the configured maximum was zero.This replaces the truthiness checks with explicit
undefinedchecks in both sibling implementations, preserving zero as a valid limit. Focused regression tests cover both the string and binary consumers.Validation:
vitest run packages/platform/node-shared/test/NodeStream.test.ts(12 tests passed)tsc -b tsconfig.jsonoxlint -f unixdprint checkRelated