Selection and configuration additional settings #3

Activity

1. PowerKiKi commented on Jul 4, 2018

   

   PowerKiKi

   on Jul 4, 2018

   Last edited by sambaptista

   Member

   More actions

   Sound mostly good to me. So that would mean something like that for the selection:

   export interface BasicConfiguration {
       // Old stuff
       display: string;
       field: string;
       transform?: (Selection) => Selection;
   
       // New stuff
       visible: boolean = true;
       unique: boolean = isFlag();
   }

   See https://github.com/Ecodev/natural-search/issues/15#issuecomment-402357359 for the preselection.

   But I am a bit confused about forced and readonly. I'd say that a preselection is always readonly. If you want to make it editable, then you must must make the configuration visible, and thus allow adding, removing and editing. And if you want to be non-editable, then you hide the configuration (and thus automatically force the preselection). I don't see a reasonable use-case where the preselection must editable, but the configuration hidden...
2. PowerKiKi

   transferred this issue fromEcodev/natural-searchon Apr 21, 2019
3. PowerKiKi

   added

   enhancementNew feature or requestNew feature or request

   natural-search

   on Apr 21, 2019
4. sambaptista commented on Aug 23, 2019

   

   sambaptista

   on Aug 23, 2019

   MemberAuthor

   More actions

   But I am a bit confused about forced and readonly. I'd say that a preselection is always readonly

   Forced prevent the selection to be removed, but allow edition.
   Readonly prevent to change the value, but allow removal.

   Take dilps/tiresias usecase : we will add a default selection "databaseSource" with default value on dilps/tiresias. User can change and can remove the filter. It's a preselection that is not forced, neither readonly.

   readonly : prevent user to change value and open dropdown (focus should still be available for deletion if allowed). Is not duplicate of a flag configuration.

   Maybe I was wrong, it seems a duplicate for flagged facet. Don't remember the difference.

   Use case : if a configuration is not visible from menu and a pre-defined selection is provided, the user should not be able to remove it, because he can't add it afterwards. The "forced" option would be implicit.

   I don't see a reasonable use-case where the preselection must editable, but the configuration hidden...

   Neither do I, but it's an implementation remark, not a feature. It's a combination we have to manage to prevent blocked situations.