Repository navigation
Conversation
jwilder/nginx-proxy:1.11.6 is still the latest release, and upstream doesn't rebuild the image between releases, so its Debian 13 packages are frozen at the July snapshot. 39 of them had updates, many from trixie-security (openssl 3.5.7, libexpat1, libpcre2, curl, libc6, tzdata). Upgrading at build time keeps the base patched; nginx itself comes from nginx.org and isn't touched.
There was a problem hiding this comment.
🟢 Approval recommended
The narrowly scoped change correctly sequences package operations, and the reported build and proxy smoke tests support approval.
No open issues 🎉
What changed in this PR
This PR updates Debian packages when building the nginx-proxy image, addressing packages left outdated between upstream image releases.
Changes:
- Adds
apt-get upgrade -yafter refreshing package indexes, before installingapache2-utils. - Documents why build-time upgrades are needed and preserves package-list cleanup.
| File | Description |
|---|---|
nginx-proxy/Dockerfile |
Applies pending Debian upgrades during the image build. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies pending Debian updates when the nginx-proxy image is built.
jwilder/nginx-proxy:1.11.6(2026-07-16) is still the latest release, and upstream doesn't rebuild the image between releases, so the Debian 13 base we build on is frozen at its July snapshot. Rebuilding our image with the same tag didn't help either: the Dockerfile only installedapache2-utils, so everything else stayed at the July versions. At build time today,apt-get upgradeupdates 39 packages, many fromtrixie-security: openssl/libssl3t64 3.5.6 → 3.5.7, libexpat1 2.7.1 → 2.9.0, libpcre2-8-0, curl/libcurl4t64, libc6, liblzma5, libpng16, libtiff6 and tzdata among them.The nginx binary comes from nginx.org, whose apt source isn't kept in the image, so it isn't touched: nginx stays at 1.31.3 until the next upstream nginx-proxy release.
Testing
apt-get upgradereports 39 upgraded, andapt list --upgradablein the built image is empty apart from nginx.nginx -v1.31.3,nginx -tpasses, Debian 13.7, OpenSSL 3.5.7,htpasswd, docker-gen 0.17.2 and forego present,/version.confunchanged.X-Powered-By: EasyEngine v4).nginx.tmplfor a backend container withVIRTUAL_HOST=smoke.test,nginx -tpasses, and a request withHost: smoke.testthrough the proxy reaches the backend.