Conversation
Play's Edits.commit rejects the parameter outright for this app — "Changes are sent for review automatically. The query parameter changesNotSentForReview must not be set." — so v1.2.2's deploy failed at the commit step with the AAB already uploaded. v1.2.1 committed fine without it; the flag was added pre-emptively for the opposite error, which this app does not produce. The two states are mutually exclusive, so only set it if Play starts refusing the other way. A failed commit abandons the edit, so v1.2.2 can be re-uploaded under the same versionCode. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…reenshots] The tab showed favourites in the order they were saved and nothing said so; the only way to move one was two entries in its own ⋮ menu, one step at a time. A sort action now sits beside the layout switch, with the current order ticked. Sorting never writes sortIndex, so switching back to the hand-made arrangement brings it out as it was — and move up/down are offered only in that order, where they can be seen to work. The marker re-records the goldens on CI: the three favourites pictures gained a top bar icon, and favourites_sorted_* is new. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.