[STACKED on #891] fix(guest): make KMS failover ordering deterministic - #946
Closed
kvinwang wants to merge 2 commits into
Closed
[STACKED on #891] fix(guest): make KMS failover ordering deterministic#946kvinwang wants to merge 2 commits into
kvinwang wants to merge 2 commits into
Conversation
kvinwang
force-pushed
the
codex/fix-guest-kms-failover-order
branch
from
July 31, 2026 03:25
4c66ddd to
15efa30
Compare
kvinwang
changed the base branch from
master
to
codex/fix-guest-gateway-private-state
July 31, 2026 03:26
kvinwang
force-pushed
the
codex/fix-guest-gateway-private-state
branch
from
August 4, 2026 08:49
8715ee1 to
73a7ff8
Compare
Base automatically changed from
codex/fix-guest-gateway-private-state
to
master
August 5, 2026 00:51
kvinwang
force-pushed
the
codex/fix-guest-kms-failover-order
branch
from
August 5, 2026 09:02
15efa30 to
7adae4d
Compare
Collaborator
Author
|
Closing because the existing implementation already performs deterministic, sequential failover in configured URL order. This change primarily refactors the loop for testing and does not address the claimed inventory-ordering root cause. URL normalization, if needed, should be proposed separately as a focused change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
KMS endpoint failover depended on map/inventory iteration order. Different runs could choose different first endpoints, causing nondeterministic latency and making recovery behavior change after restart.
Root cause and fix
Sort/retain an explicit endpoint order and apply failover in that deterministic sequence.
Implementation
The branch records the following focused implementation work:
fix(guest): make KMS failover ordering testablestyle(guest): format KMS failover testsChanged paths:
dstack/dstack-util/src/system_setup.rsScope
This PR addresses one logical
guestfinding. It intentionally excludes the acceptance-test infrastructure from #841 and unrelated product fixes from #840.Dependency and merge order
codex/fix-guest-gateway-private-stateVerification
git diff --check origin/codex/fix-guest-gateway-private-state..origin/codex/fix-guest-kms-failover-order: passed.