Skip to content

fix(verifier): validate configuration precedence - #940

Merged
kvinwang merged 4 commits into
masterfrom
codex/fix-verifier-config-precedence
Aug 5, 2026
Merged

fix(verifier): validate configuration precedence#940
kvinwang merged 4 commits into
masterfrom
codex/fix-verifier-config-precedence

Conversation

@kvinwang

@kvinwang kvinwang commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Problem

Verifier assembled settings from defaults, file/environment, and CLI in an order that could let a lower-priority source overwrite an explicit higher-priority value. The service then ran with different trust/network settings than the operator requested.

Root cause and fix

Apply and validate configuration sources in the documented precedence order, preserving explicit overrides.

Implementation

The branch records the following focused implementation work:

  • fix(verifier): validate configuration precedence
  • fix(verifier): escape image template diagnostic

Changed paths:

  • dstack/dstack-attest/src/attestation.rs
  • dstack/dstack-types/src/lib.rs
  • dstack/verifier/src/main.rs

Scope

This PR addresses one logical verifier finding. It intentionally excludes the acceptance-test infrastructure from #841 and unrelated product fixes from #840.

Dependency and merge order

This PR is based directly on master and does not require another split product PR to merge first.

Verification

  • git diff --check origin/master..origin/codex/fix-verifier-config-precedence: passed.
  • The declared base was verified as an ancestor of the PR head.
  • Focused compile/check verification was run for the changed component where applicable; non-Rust packaging or configuration changes were reviewed against their exact branch delta.

Copilot AI review requested due to automatic review settings July 31, 2026 03:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@kvinwang
kvinwang merged commit 11c80d0 into master Aug 5, 2026
15 checks passed
@kvinwang
kvinwang deleted the codex/fix-verifier-config-precedence branch August 7, 2026 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants