fix(tee-simulator): generate ACPI event digests - #1056
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the TDX tee-simulator’s simulated evidence consistency by regenerating the ACPI-related RTMR0 digests from the configured VM measurement and patching the CCEL fixture accordingly before replaying RTMRs and emitting the CCEL to the guest.
Changes:
- Add
ccel_for_config()to patch the bundled CCEL fixture’s ACPI event digests to matchexpected_rtmr0_acpi_hashes()derived fromvm_config. - Ensure RTMR replay/quote generation uses the patched CCEL when a measurement document is provided.
- Add a regression test asserting the CCEL ACPI event digests match the generated expected digests.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The simulator combined the current
vm_configwith stale ACPI digests from its bundled CCEL fixture after #1053. This produced internally inconsistent simulated evidence that the verifier correctly rejected.Testing
cargo fmt --manifest-path dstack/Cargo.toml --all --checkcargo test --manifest-path dstack/Cargo.toml -p dstack-tee-simulatoris_valid, quote, event log, OS image hash, and ACPI tables all verified)