refactor: remove legacy fallback in toggle_location_services - #6
Conversation
Removed the deprecated fallback logic in `toggle_location_services` that used the `TOGGLE_LOCATION_SERVICES` command. The method now exclusively uses the `mobile: toggleGps` script. Also removed the `TOGGLE_LOCATION_SERVICES` constant from `MobileCommand` and its registration in `Location._add_commands`, as it is no longer used. Updated `test/unit/webdriver/device/location_test.py` to verify the new behavior.
Removed the deprecated fallback logic in `toggle_location_services` that used the `TOGGLE_LOCATION_SERVICES` command. The method now exclusively uses the `mobile: toggleGps` script. Also removed the `TOGGLE_LOCATION_SERVICES` constant from `MobileCommand` and its registration in `Location._add_commands`, as it is no longer used. Updated `test/unit/webdriver/device/location_test.py` to verify the new behavior.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Closing — no longer relevant against upstream ( Generated by Claude Code |
1 participant
🎯 What: Removed the legacy fallback logic in
toggle_location_servicesand the associatedTOGGLE_LOCATION_SERVICEScommand.💡 Why: Improves maintainability by removing deprecated technical debt and relying solely on the modern
mobile: toggleGpsscript.✅ Verification: Verified syntax with
py_compileand updated unit tests to ensure correct script execution.✨ Result: Simplified
toggle_location_servicesimplementation and removed dead code.PR created automatically by Jules for task 12199018167299631792 started by @Dor-bl