Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #148 +/- ##
=======================================
Coverage 99.23% 99.23%
=======================================
Files 12 12
Lines 781 784 +3
=======================================
+ Hits 775 778 +3
Misses 6 6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ptsOSL
force-pushed
the
asyncio-conversion
branch
from
October 15, 2025 09:36
88b8a36 to
3ccbca6
Compare
ptsOSL
commented
Oct 15, 2025
ptsOSL
commented
Oct 15, 2025
This is the majority of the changes required to make the code asyncio complient and to switch to aioca.
Namely converting get_single()
Awaited on functions where required. I also had to switch to AsyncMock from MagicMock anywhere that a function needed to return a coroutine.
The special patter of making a class object return true or false using __bool__ is for sync code only
Some devices need awaiting and some dont
ptsOSL
force-pushed
the
asyncio-conversion
branch
from
October 1, 2026 13:24
3ccbca6 to
9d5116b
Compare
This will add a slight overhead when interacting with devices that dont do async operations, but its worth it to simplify the code and speed up async devices by removing if statement.
ptsOSL
force-pushed
the
asyncio-conversion
branch
from
October 7, 2026 12:02
9d5116b to
08baff8
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert pytac from using cothread to aioca. This requires us to adopt asyncio.
This will be a breaking change for pytac and we will not support backwards compatibility.