IShader, no more conversions, stage is now part of spec info. by devshgraphicsprogramming · Pull Request #839 · Devsh-Graphics-Programming/Nabla

devshgraphicsprogramming · 2025-02-21T21:46:54Z

Description

Remove unnecessary complexity of ICPUShader and IGPUShader.

Testing

All examples using shaders need to be tested.

TODO list:

require maintenance5 or graphics_pipeline_library
pass SPIR-V directly to pipeline creation without creating a VkShaderModule using maintenance5/graphics_pipeline_library pNext new API
set debug object name on created graphics pipeline libraries
use SPIR-V Tools & Opt to create a copy of the SPIR-V, remove entry points not used by spec info, then run DCE and capability stripping pass

…d moves spec info out

# Conflicts: # src/nbl/asset/utils/CHLSLCompiler.cpp

We want to keep SShaderSpecInfo as POD

…null content.

# Conflicts: # src/nbl/video/ILogicalDevice.cpp # src/nbl/video/utilities/CAssetConverter.cpp

# Conflicts: # src/nbl/video/utilities/CAssetConverter.cpp

devshgraphicsprogramming · 2025-06-17T21:29:26Z

Everything resolved, work continues in #887

first commit that turns IGPUShader and ICPUShader into one IShader an…

6fd47aa

…d moves spec info out

devshgraphicsprogramming assigned alichraghi Feb 21, 2025

devshgraphicsprogramming added 4 commits February 21, 2025 23:56

Asset Converter should work after this change

92a58ea

correct the eggregious typos, add TODOs

7e3d71c

touch up the Vulkan Pipelines to not hold onto shaders

2370636

fix more typos, and add one more TODO

38dd6e5

This was referenced Mar 10, 2025

Pipeline Libraries #853

Open

Deprecate Pipeline Cache, replace with Pipeline Binaries #854

Open

Ray Tracing Pipeline #820

Merged

kevyuu added 7 commits March 27, 2025 16:50

Create pipeline now use spir-v directly

499f57b

Remove constructor. this overload conflict with another constructor.

40d744e

FIx spirv introspector

e7beb7e

Fix CComputeBlit to use IShader

782bf4c

Merge branch 'master' into stagesless_shaders

a2f7d91

# Conflicts: # src/nbl/asset/utils/CHLSLCompiler.cpp

Fix asset converter to support the new IShader

82dc575

Fix NSC to use AssetMetadata to get shader stage

19b0c21

devshgraphicsprogramming commented Mar 31, 2025

View reviewed changes

Comment thread include/nbl/asset/IPipeline.h Outdated

devshgraphicsprogramming commented Mar 31, 2025

View reviewed changes

Comment thread include/nbl/asset/IShader.h Outdated

devshgraphicsprogramming commented Mar 31, 2025

View reviewed changes

Comment thread include/nbl/video/utilities/CAssetConverter.h Outdated

devshgraphicsprogramming commented Mar 31, 2025

View reviewed changes

Comment thread include/nbl/asset/metadata/CHLSLMetadata.h Outdated

devshgraphicsprogramming commented Mar 31, 2025

View reviewed changes

Comment thread src/nbl/video/utilities/CAssetConverter.cpp

kevyuu added 9 commits April 1, 2025 18:10

use std::string_view for shader entry points

7be8def

We want to keep SShaderSpecInfo as POD

remove getObjectDebugName from IShader

1a8ea98

disable IShader patching

a428d4d

Disable IShader patching

8028703

Fix by adding static to getLoogingLabel

36e6f33

Enable HLSLMetadata to support multiple shader stages

7c548b7

Expose more option in ISPIRVOptimizer

64875ac

Implement ISPIRVDebloater

94cc246

expose dead constant elim optimization in ISPIRVOptimizer

565fd4a

kevyuu added 4 commits April 14, 2025 17:30

Refactor ray tracing to use SPIRVDebloater

d18de3b

Remove unfoundEntryPoint and use a counter to make it more efficient

597516f

print debug information in spirv debloater in debug mode

9f3f823

Fix spirvdebloater when debloat is not needed

2e89fa2