Skip to content

Remove Matrices - #760

Closed
devshgraphicsprogramming wants to merge 465 commits into
camerazfrom
rm_core_mat_vec
Closed

Remove Matrices#760
devshgraphicsprogramming wants to merge 465 commits into
camerazfrom
rm_core_mat_vec

Conversation

@devshgraphicsprogramming

@devshgraphicsprogramming devshgraphicsprogramming commented Oct 25, 2024

Copy link
Copy Markdown
Member

Description

Testing

TODO list:

devshgraphicsprogramming
devshgraphicsprogramming commented Oct 25, 2024
View reviewed changes
Comment thread include/nbl/builtin/hlsl/glsl_compat/math.hlsl Outdated
devshgraphicsprogramming
devshgraphicsprogramming commented Oct 25, 2024
View reviewed changes
Comment thread include/nbl/builtin/hlsl/glsl_compat/math.hlsl Outdated
Comment on lines +22 to +42
template<typename T>
inline T radians(NBL_CONST_REF_ARG(T) degrees)
{
static_assert(
is_floating_point<T>::value,
"This code expects the type to be either a double or a float."
);

return degrees * PI<T>() / T(180);
}

template<typename T>
inline T degrees(NBL_CONST_REF_ARG(T) radians)
{
static_assert(
is_floating_point<T>::value,
"This code expects the type to be either a double or a float."
);

return radians * T(180) / PI<T>();
}

@devshgraphicsprogramming devshgraphicsprogramming Oct 25, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have numbers ot something like that for PI and friends.

Also the _HLSL_VERSION case should forward to the inline SPIR-V from the std450 extended set

devshgraphicsprogramming
devshgraphicsprogramming commented Oct 25, 2024
View reviewed changes
Comment thread include/nbl/builtin/hlsl/math/quaternion/quaternion.hlsl Outdated
Comment on lines +52 to +53
DEFINE_MUL_QUATERNION_BY_SCALAR_OPERATOR(uint32_t)
DEFINE_MUL_QUATERNION_BY_SCALAR_OPERATOR(uint64_t)

@devshgraphicsprogramming devshgraphicsprogramming Oct 25, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a mistake, only provide mul with T

AnastaZIuk
AnastaZIuk reviewed Oct 25, 2024
View reviewed changes
Comment thread include/nbl/builtin/hlsl/matrix_utils/transformation_matrix_utils.hlsl Outdated
AnastaZIuk
AnastaZIuk reviewed Oct 25, 2024
View reviewed changes
Comment thread include/nbl/builtin/hlsl/matrix_utils/transformation_matrix_utils.hlsl Outdated
AnastaZIuk
AnastaZIuk reviewed Oct 25, 2024
View reviewed changes
Comment thread include/nbl/builtin/hlsl/matrix_utils/transformation_matrix_utils.hlsl Outdated
AnastaZIuk
AnastaZIuk reviewed Oct 25, 2024
View reviewed changes
Comment thread include/nbl/builtin/hlsl/matrix_utils/transformation_matrix_utils.hlsl
AnastaZIuk
AnastaZIuk reviewed Oct 25, 2024
View reviewed changes
Comment thread include/nbl/builtin/hlsl/matrix_utils/transformation_matrix_utils.hlsl
AnastaZIuk added a commit that referenced this pull request Oct 25, 2024
@AnastaZIuk
steal include/nbl/builtin/hlsl/matrix_utils/transformation_matrix_uti…
22f505c 
…ls.hlsl from #760
AnastaZIuk added a commit that referenced this pull request Oct 25, 2024
@AnastaZIuk
fix getMatrix3x4As4x4 (return type issues) & buildCameraLookAtMatrixR…
51f4ced 
…H (ambiguity dependent type issues), reference #760
AnastaZIuk
AnastaZIuk reviewed Oct 25, 2024
View reviewed changes
Comment thread include/nbl/builtin/hlsl/matrix_utils/transformation_matrix_utils.hlsl Outdated
AnastaZIuk
AnastaZIuk reviewed Oct 25, 2024
View reviewed changes
Comment thread include/nbl/builtin/hlsl/matrix_utils/transformation_matrix_utils.hlsl Outdated
AnastaZIuk
AnastaZIuk reviewed Oct 25, 2024
View reviewed changes
Comment thread include/nbl/builtin/hlsl/matrix_utils/transformation_matrix_utils.hlsl Outdated
AnastaZIuk added a commit to Devsh-Graphics-Programming/Nabla-Examples-and-Tests that referenced this pull request Oct 25, 2024
@AnastaZIuk
address https://github.com/Devsh-Graphics-Programming/Nabla/pull/760/…
0415999 
…files#r1816728485 comment in Devsh-Graphics-Programming/Nabla#760 PR
AnastaZIuk added a commit that referenced this pull request Oct 25, 2024
@AnastaZIuk
actually *this* addresses https://github.com/Devsh-Graphics-Programmi…
f1daa25 
…ng/Nabla/pull/760/files#r1816728485 for #760 PR, update examples_tests submodule
@Przemog1
Przemog1 changed the base branch from master to cameraz November 4, 2024 13:28
AnastaZIuk
AnastaZIuk reviewed Nov 4, 2024
View reviewed changes
Comment thread cmake/adjust/flags.cmake
AnastaZIuk
AnastaZIuk reviewed Nov 4, 2024
View reviewed changes
Comment thread include/nbl/builtin/hlsl/matrix_utils/transformation_matrix_utils.hlsl Outdated

// TODO: if `IdentityFloat32_t3x4` and `IdentityFloat32_t3x4` constexprs are ok, then I can expand them into templated struct, not doing it untill the concept is approved
//template<typename T, uint32_t N, uint32_t M>
//struct IdentityMatrix

@AnastaZIuk AnastaZIuk Nov 4, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add

template<typename T>
concept MatrixType = requires 
{
  typename T::Base::row_type;
  typename T::Base::col_type;
  typename T::Base::value_type;
} && std::is_base_of_v<glm::mat<T::Base::row_type::length(), T::Base::col_type::length(), typename T::Base::value_type>, typename T::Base>;

to matrix.hlsl just after definition (but ask @devshgraphicsprogramming if it should be named MatrixType)

then create diagonal utility

template<MatrixType Matrix>
constexpr inline Matrix diagonal(float scalar)
{
  return Matrix(scalar);
}

you can also template the scalar actually and make it value_type of the Matrix, now note that

  • matrix<T, N, M>(scalar) creates a diagonal matrix with scalar put on the diagonal
  • if your N == M then matrix<T, N, M>(1.f) is the identity matrix you need

so following diagonal create identity function (not struct!), you should be able to

using any_square_matrix_t = float32_t3x3;
constexpr auto bruh = hlsl::identity<any_square_matrix_t>()

have constraints on the template parameter, let's allow only for square matrices

@Przemog1 Przemog1 Nov 4, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but this is not C++ only file

@Przemog1 Przemog1 Nov 4, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so we can't use concepts..

@AnastaZIuk AnastaZIuk Nov 4, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so we can't use concepts..

hehe, you can! 492a0ad

@devshgraphicsprogramming devshgraphicsprogramming Nov 13, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

  typename T::Base::row_type;
  typename T::Base::col_type;
  typename T::Base::value_type;

this is specific to GLM and won't pass in plain HLSL

AnastaZIuk
AnastaZIuk reviewed Nov 4, 2024
View reviewed changes
Comment thread include/nbl/builtin/hlsl/matrix_utils/transformation_matrix_utils.hlsl Outdated
//{
//
//};
NBL_CONSTEXPR hlsl::float32_t3x4 IdentityFloat32_t3x4 =

@AnastaZIuk AnastaZIuk Nov 4, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets not hardcode and follow this comment

AnastaZIuk
AnastaZIuk reviewed Nov 4, 2024
View reviewed changes
Comment thread include/nbl/builtin/hlsl/matrix_utils/transformation_matrix_utils.hlsl Outdated
//};
NBL_CONSTEXPR hlsl::float32_t3x4 IdentityFloat32_t3x4 =
hlsl::float32_t3x4(hlsl::float32_t4(1, 0, 0, 0), hlsl::float32_t4(0, 0, 1, 0), hlsl::float32_t4(0, 0, 1, 0));
NBL_CONSTEXPR hlsl::float32_t4x4 IdentityFloat32_t4x4 =

@AnastaZIuk AnastaZIuk Nov 4, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets not hardcode and follow this comment

@Przemog1 Przemog1 Nov 14, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

AnastaZIuk
AnastaZIuk reviewed Nov 4, 2024
View reviewed changes
Comment thread include/nbl/builtin/hlsl/matrix_utils/transformation_matrix_utils.hlsl Outdated
// TODO: this is temporary function, delete when removing vectorSIMD
template<typename T>
matrix<T, 4, 4> getMatrix3x4As4x4(const matrix<T, 3, 4>& mat)
inline core::vectorSIMDf transformVector(const matrix<T, 4, 4>& mat, const core::vectorSIMDf& vec)

@AnastaZIuk AnastaZIuk Nov 4, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we also remove SIMD vectors?

@Przemog1 Przemog1 Nov 4, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do in other pr

AnastaZIuk
AnastaZIuk reviewed Nov 4, 2024
View reviewed changes
Comment thread include/nbl/builtin/hlsl/matrix_utils/transformation_matrix_utils.hlsl
matrix<T, 4, 4> getMatrix3x4As4x4(const matrix<T, 3, 4>& mat)
inline core::vectorSIMDf transformVector(const matrix<T, 4, 4>& mat, const core::vectorSIMDf& vec)
{
core::vectorSIMDf output;

@AnastaZIuk AnastaZIuk Nov 4, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/Devsh-Graphics-Programming/Nabla/pull/760/files#r1828132005

@Przemog1 Przemog1 Nov 4, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will remove every occurance of the simd vector when I work on it, no need to spam xd

AnastaZIuk
AnastaZIuk reviewed Nov 4, 2024
View reviewed changes
Comment thread include/nbl/builtin/hlsl/matrix_utils/transformation_matrix_utils.hlsl Outdated
namespace transformation_matrix_utils_impl
{
template<typename T>
inline T determinant_helper(const matrix<T, 3, 3>& mat, vector<T, 3>& r1crossr2)

@AnastaZIuk AnastaZIuk Nov 4, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please document that your returned determinant is yielded by scalar triple product

AnastaZIuk
AnastaZIuk reviewed Nov 4, 2024
View reviewed changes
Comment thread include/nbl/builtin/hlsl/matrix_utils/transformation_matrix_utils.hlsl
const vector<T, 3> zaxis = glm::normalize(position - target);
const vector<T, 3> xaxis = glm::normalize(hlsl::cross(upVector, zaxis));
const vector<T, 3> yaxis = hlsl::cross(zaxis, xaxis);
static_assert(N >= 3 && M >= 3);

@AnastaZIuk AnastaZIuk Nov 4, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of doing static_assert lets have it in requires clause

@Przemog1 Przemog1 Nov 4, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't do since it is not C++ only file

@AnastaZIuk AnastaZIuk Nov 5, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can, NBL_FUNC_REQUIRES

AnastaZIuk
AnastaZIuk reviewed Nov 4, 2024
View reviewed changes
Comment thread include/nbl/builtin/hlsl/matrix_utils/transformation_matrix_utils.hlsl Outdated
const vector<T, 3>& target,
const vector<T, 3>& upVector)
template<typename T, uint32_t N, uint32_t M>
inline matrix<T, 3, 3> getSub3x3TransposeCofactors(const matrix<T, N, M>& mat)

@AnastaZIuk AnastaZIuk Nov 4, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please document it returns adjugate (transpose of the cofactor matrix) of sub 3x3 mat matrix

AnastaZIuk
AnastaZIuk reviewed Nov 4, 2024
View reviewed changes
Comment thread include/nbl/core/math/glslFunctions.h
NBL_FORCE_INLINE T dot(const T& a, const T& b);
NBL_FORCE_INLINE T dot(const T& a, const T& b)
{
static_assert(!(std::is_same_v<T, hlsl::float32_t2> || std::is_same_v<T, hlsl::float32_t3> || std::is_same_v<T, hlsl::float32_t4>));

@AnastaZIuk AnastaZIuk Nov 4, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to requires clause

@Przemog1 Przemog1 Nov 4, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't do since it is not C++ only file

@AnastaZIuk AnastaZIuk Nov 5, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can, NBL_FUNC_REQUIRES

alichraghi and others added 25 commits January 19, 2025 00:38
@alichraghi
box_blur: move into here from example code
19973ac 
Signed-off-by: Ali Cheraghi <alichraghi@proton.me>
@Fletterio
Address all PR comments
5518e01
@devshgraphicsprogramming
Merge pull request #818 from Devsh-Graphics-Programming/more_fft_utils
0f8bcac 
FFT Fixes
@Fletterio
FFT readme update
2e52107
@Fletterio
Update examples submodule ptr
ae5dbad
@alichraghi
prefix_sum_blur: address reviews
d2adf17 
Signed-off-by: Ali Cheraghi <alichraghi@proton.me>
@Fletterio
FFT readme update and accessor concept change to remove memory barriers
2782d8d
@Fletterio
FFT readme update
a46b9b0
@alichraghi
box_sampler: rework ETC_REPEAT
b65dc7f 
Signed-off-by: Ali Cheraghi <alichraghi@proton.me>
@alichraghi
box_sampler: simplify ETC_MIRROR
6f74af2 
Signed-off-by: Ali Cheraghi <alichraghi@proton.me>
@alichraghi
blake3: add reset()
75ffca1 
Signed-off-by: Ali Cheraghi <alichraghi@proton.me>
@AnastaZIuk
Merge pull request #822 from Devsh-Graphics-Programming/ali_blake_reset
43323a6 
blake3: add reset()
@alichraghi
box_sampler: update ETC_REPEAT
b1f2827 
Signed-off-by: Ali Cheraghi <alichraghi@proton.me>
@devshgraphicsprogramming
Merge pull request #819 from Devsh-Graphics-Programming/ali_blur3
45d97fd 
Prefix sum box blur
@devshgraphicsprogramming
post Prefix Sum Bloom merge submodule update
bacb479
@Fletterio
Update submodule pointer
f4b2626
@alichraghi
video: update profiles
1e05ae4 
Signed-off-by: Ali Cheraghi <alichraghi@proton.me>
@alichraghi
video: remove bad report and exclude android from core profile
68ca358 
Signed-off-by: Ali Cheraghi <alichraghi@proton.me>
@devshgraphicsprogramming
Merge pull request #824 from Devsh-Graphics-Programming/ali_profiles
4786926 
video: update profiles
@Crisspl
Fix false positive aspect mask error raising
eac5159
@devshgraphicsprogramming
Merge pull request #826 from Crisspl/quick-fix
72bd107 
Fix false positive aspect mask error raising
@alichraghi
cmake: no longer dies when NBL_SANITIZE_ADDRESS is ON
25ef700 
Signed-off-by: Ali Cheraghi <alichraghi@proton.me>
@alichraghi
video: free command buffers when destroyed
d8e5751 
Signed-off-by: Ali Cheraghi <alichraghi@proton.me>
@devshgraphicsprogramming
Merge pull request #830 from Devsh-Graphics-Programming/ali_cmd
8b67720 
video: free command buffers when destroyed
@Przemog1
Resolved conflicts, merged master
4a894fe
@Przemog1 Przemog1 closed this Feb 7, 2025
@Przemog1
Przemog1 deleted the rm_core_mat_vec branch February 7, 2025 10:12
@devshgraphicsprogramming devshgraphicsprogramming mentioned this pull request Feb 26, 2025
Open
AnastaZIuk added a commit to Devsh-Graphics-Programming/Nabla-Examples-and-Tests that referenced this pull request Apr 10, 2026
@AnastaZIuk
address https://github.com/Devsh-Graphics-Programming/Nabla/pull/760/…
b7e6d9e 
…files#r1816728485 comment in Devsh-Graphics-Programming/Nabla#760 PR
Erfan-Ahmadi added a commit that referenced this pull request Sep 19, 2026
@AnastaZIuk @Erfan-Ahmadi
Cameraz (#995)
bf9970e 
* add operator= for glm:: matrices corresponding to our at home matrices - we were never be able to do ourMatrixT = glmMatrixT and its important since a lot of utils create glmMatrixT actually

* I'm stupid, I have explicit at home matrix constructor taking glm:: matrix xD remove the = operator glm -> to ours

* steal include/nbl/builtin/hlsl/matrix_utils/transformation_matrix_utils.hlsl from #760

* fix getMatrix3x4As4x4 (return type issues) & buildCameraLookAtMatrixRH (ambiguity dependent type issues), reference #760

* update examples_tests submodule

* actually *this* addresses https://github.com/Devsh-Graphics-Programming/Nabla/pull/760/files#r1816728485 for #760 PR, update examples_tests submodule

* update examples_tests submodule

* update examples_tests submodule

* forgot to commit projection build methods, update examples_tests submodule

* add is_smart_refctd_ptr_v, update examples_tests submodule

* update examples_tests submodule

* update examples_tests submodule

* update examples_tests submodule

* create ui::E_MOUSE_CODE & constexpr ui::mouseCodeToString - we really were missing an equivalent of E_KEY_CODE. Update examples_tests submodule

* @alichraghi small homework - read https://en.cppreference.com/w/cpp/language/inline and afterwards https://gudok.xyz/inline/ please

* update examples_tests submodule

* update examples_tests submodule

* update examples_tests submodule

* update examples_tests submodule

* update imguizmo with its upstream

* update examples_tests submodule

* update examples_tests submodule

* update examples_tests submodule

* update examples_tests submodule

* add getCastedMatrix & getCastedVector, update examples_tests submodule

* update examples_tests submodule

* update examples_tests submodule

* add examples_tests submodule

* update examples_tests submodule

* update examples_tests submodule

* update examples_tests submodule

* update examples_tests submodule

* add constexpr stringToKeyCode & stringToMouseCode

* update examples_tests submodule

* update examples_tests submodule

* update examples_tests submodule

* update examples_tests submodule

* update examples_tests submodule

* update examples_tests submodule

* update examples_tests submodule

* update examples_tests submodule

* update examples_tests submodule

* update examples_tests submodule

* update examples_tests submodule

* update examples_tests submodule

* update examples_tests submodule

* update examples_tests submodule

* update examples_tests submodule

* update examples_tests submodule

* a comment for glslFunctions, update examples_tests submodule

* small temporary updates to transformation_matrix_utils.hlsl, update examples_tests submodule

* introduce reference frame concept to imguizmo - commit submodule update

* update examples_tests submodule

* update examples_tests submodule

* imgui log polish

* Update camera module and async dispatcher exit

* Restore transformation matrix utils compatibility

* Update examples_tests submodule pointer

* Update examples_tests submodule pointer

* Update examples_tests pointer for world axis fix

* Update examples tests camera smoke integration

* Add frustum extension and camera smoke updates

* Update examples tests continuity frustum script

* Update camera test submodule revision

* Update examples_tests submodule revision

* Update examples_tests for cameraz smoke fixes

* Update examples_tests after master merge

* Update examples_tests after json alias fix

* Update examples_tests checkpoint

* Update examples_tests after goal solver rename

* Update examples_tests after camera goal cleanup

* Update examples_tests after camera goal solver changes

* Update examples_tests after preset compatibility changes

* Update examples_tests after preset policy changes

* Update examples_tests after Chase and Dolly preset flow checks

* Update examples_tests after planar binding cleanup

* Update examples_tests after camera contract cleanup

* Update examples_tests after input binding helper cleanup

* Update examples_tests after transform editor cleanup

* Update examples_tests after binding layout rename

* Update examples_tests after binding storage split

* Update examples_tests after binding layout header split

* Update examples_tests after JSON binding rename

* Update examples_tests after input processor rename

* Update examples_tests after camera rig setup cleanup

* Update examples_tests after rig config routing

* Update examples_tests after rig preset helper cleanup

* Update examples_tests after camera binding layout decoupling

* Update examples_tests after binding naming cleanup

* Update examples_tests after camera binding cleanup

* Update examples_tests after motion config split

* Update examples_tests after scoped motion overrides

* Update examples_tests after unit motion wrapper

* Update examples_tests after goal alias cleanup

* Update examples_tests after preset UI cleanup

* Update examples_tests after playback summary changes

* Update examples_tests after preset banner cleanup

* Update examples_tests after playback scrub preview

* Update examples_tests after capture gating

* Update examples_tests after shared goal API cleanup

* Update examples_tests after shared preset API cleanup

* Update examples_tests after playback keyframe authoring cleanup

* Update examples_tests after keyframe storage changes

* Update examples_tests after shared analysis cleanup

* Update examples_tests after shared keyframe track cleanup

* Update examples_tests after camera docs

* Update examples_tests after header docs

* Update examples_tests after playback timeline cleanup

* Update examples_tests after camera persistence cleanup

* Update examples_tests after preset flow cleanup

* Update examples_tests after preset apply summary cleanup

* Update examples_tests after camera helper smoke hardening

* Update examples_tests after camera helper polish

* Update examples_tests after camera manipulation cleanup

* Update examples_tests after camera text cleanup

* Update examples_tests after camera projection cleanup

* Update examples_tests after analysis text cleanup

* Update examples_tests after helper smoke hardening

* Update examples_tests after presentation cleanup

* Update examples_tests after presentation badge cleanup

* Update examples_tests after preset comparison cleanup

* Update examples_tests after presentation label cleanup

* Update examples_tests after preset collection cleanup

* Update examples_tests after continuity scripting cleanup

* Update examples_tests after follow integration

* Update examples_tests after follow integration

* Update examples_tests after sequence policy cleanup

* Update examples_tests after scripted runtime cleanup

* Update examples_tests after camera docs rewrite

* Update examples_tests after camera API cleanup

* Update examples_tests after camera cleanup

* Update examples_tests after camera contract cleanup

* Update examples_tests after ui presentation cleanup

* Update examples_tests after follow label cleanup

* Update examples_tests after system follow cleanup

* Update examples_tests after hlsl cleanup

* Update examples_tests after docs cleanup

* Update examples_tests after header docs

* Polish hlsl transform utility cleanup

* Update examples_tests after camera cleanup

* Update examples_tests after camera cleanup

* Move cameras module into ext

* Clean up cameras ext module

* Polish cameras README

* Trim non-camera drift from cameras ext

* Use shared quaternion cast in cameras

* Restore dxc submodule pointer

* Split cameras utilities into source files

* Move gimbal input processing into source files

* Revert shared quaternion cast change

* Restore shared quaternion cast

* Use bitmask helpers for goal solver issues

* Update examples_tests submodule

* Refresh examples cameraz submodule

* Refresh examples cameraz submodule

* Fix GitHub math in cameras README

* Fix Path Rig math rendering

* Refresh examples cameraz submodule

* Refresh examples cameraz submodule

* Refresh examples cameraz submodule

* Fix camera scaling and view accessors

* bug fixes and minor typo fixes to input system

* update examples after merge with master

* new hlsl::approx helpers and ieee754 fixes and improvements + update README

* camera namespace changes + minor fixes + remove useless classes

* cleanup math utilities, use hlsl:: as much as possible and remove redundant math util functions, consistent matrix conventions (mat4x4 vs new CameraBasis).

* more cleanups and refactors, better names, remove ReferenceTransform and replace with RigPose, seperate mat4x4 from manipulate calls into a `setPose` function. a bit more documentations. remove passthrough functions that add to confusion and bloat the codebase.

* cleanup gimball and manipulation counters, a little cleanip on camera follow utils. move stuff to cpp

* The layer that captured one camera's state into a `CCameraGoal` and applied it to another camera, plus everything built on it (presets, keyframe tracks, playback, persistence, follow, sequence scripts, the scripted runtime and its checks), now lives in `examples_tests/61_UI/include/camera/`

* update examples

* update examples

* update examples

* new camera controls and input processing

* update examples

* update examples + fix wrong input pruning

* Move files from camera extension to UI example and update Copyright years

* update README

* cleanup projection stuff in camera extension, proper names (distinction between projection and cameraWithProjection)

* update readme of camera ext

* Camera extension math utils cleanups and refactors

* update examples_tests

---------

Co-authored-by: Erfan Ahmadi <ahmadierfan99@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Przemog1 Przemog1 Przemog1 left review comments
@AnastaZIuk AnastaZIuk AnastaZIuk left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@devshgraphicsprogramming @Przemog1 @AnastaZIuk @Fletterio @Erfan-Ahmadi @keptsecret @alichraghi @deprilula28 @YasInvolved @Crisspl