Repository navigation
Guard ticket signing against observed epoch changes - #7
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A relay usage report can be measured in epoch N while ticket creation later reads epoch N+1. Previously, the old byte total could be signed as a new-epoch ticket.
Bind each validated usage report to the observed ticket epoch and report sequence. Reject and retry when either changes before or during signing, including during a
too_lowrepair. Normal reconnect and cold-start behavior remains. Bump diodejs to 0.5.10.The relay's v1001 report contains no usage epoch, so this guards observable changes but cannot prove the epoch of every report. Complete protection needs an epoch-tagged relay response.
Validation: full Node 20 and Node 22 suites passed (292 tests each) on the final commit; npm pack dry-run passed.