-
Notifications
You must be signed in to change notification settings - Fork 1
Chore: Code cleanup for AssetBundleManager #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SniffBakaSniff
wants to merge
7
commits into
feat_AssetBundleManager
Choose a base branch
from
chore/code-cleanup
base: feat_AssetBundleManager
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
f21578a
chore/code-cleanup
SniffBakaSniff 3aeb908
Update plugin version
SniffBakaSniff 24f73b4
fix(scenemanager): resolve waiter leak, async reload race, and child …
Cyrusbye720 9857fdb
fix(scenemanager): handle load exceptions and self-destruct waiter on…
Cyrusbye720 5475abc
fix(scenemanager): guard against concurrent scene loads and check emp…
Cyrusbye720 f66345b
fix(scenemanager): prevent stale disabled renderers, remove startup w…
Cyrusbye720 523a54a
fix(scenemanager): prevent unloading and loading base gameplay scene …
Cyrusbye720 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: The plugin metadata no longer matches the repository’s contract tests, which require
Deadshot Mod Apiand version0.0.1; the metadata test now fails.Assessment: 🟠
Major· 🔁Occurrence: Often· 🏷️Api mismatchPrompt for AI Agent 🤖