Skip to content

curve: exclude blacklisted pools - #3011

Merged
0xkr3p merged 1 commit into
masterfrom
fix/curve-pools-blacklist
Sep 22, 2026
Merged

0xkr3p merged 1 commit into
masterfrom
fix/curve-pools-blacklist

Conversation

@0xkr3p

@0xkr3p 0xkr3p commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes
    • Excluded pools identified on Curve’s blacklist from Curve DEX data.
    • Added coverage for additional blacklisted pools across Ethereum, Fantom, and Arbitrum.
    • Improved resilience when the blacklist cannot be retrieved by continuing without blacklist data.

@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 436a236a-cb33-4793-bcaa-22faf14beee2

📥 Commits

Reviewing files that changed from the base of the PR and between 0ab810b and 6f18bab.

📒 Files selected for processing (3)
  • src/adaptors/curve-dex/config.js
  • src/adaptors/curve-dex/index.js
  • src/utils/exclude.js

Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The Curve adaptor now retrieves chain-specific pool blacklist data, passes it through the blockchain processing flow, and skips matching pools. Static exclusions add 11 blacklisted Curve pools across Ethereum, Fantom, and Arbitrum.

Changes

Curve pool blacklist filtering

Layer / File(s) Summary
Blacklist configuration and retrieval
src/adaptors/curve-dex/config.js, src/adaptors/curve-dex/index.js
The adaptor defines the Curve pool filters URL, fetches blacklist entries, and stores lowercase pool addresses in chain-specific Set values.
Blacklist propagation and pool exclusion
src/adaptors/curve-dex/index.js, src/utils/exclude.js
The blockchain flow passes blacklist data to feedLlama, which skips matching pools. Static exclusions add 11 Curve pool identifiers across Ethereum, Fantom, and Arbitrum.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~15 minutes

Change: Bug fix

Sequence Diagram(s)

sequenceDiagram
  participant Main
  participant getBlacklistedPools
  participant CurvePoolFiltersAPI
  participant feedLlama
  Main->>getBlacklistedPools: Request blacklist
  getBlacklistedPools->>CurvePoolFiltersAPI: Fetch pool filters
  CurvePoolFiltersAPI-->>getBlacklistedPools: Return chain pool addresses
  getBlacklistedPools-->>Main: Return lowercase address Sets
  Main->>feedLlama: Pass blacklist with blockchain data
  feedLlama-->>Main: Return pools excluding blacklisted addresses
Loading

Suggested reviewers: slasher125

Merge Risk: ⚪ Minimal · up to 6f18b

The change filters blacklisted Curve pools using remote and static data, with no evidenced correctness, availability, or deployment risk remaining; it is ready to merge.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: excluding Curve pools listed in the blacklist.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

The curve-dex adapter exports pools:

Test Suites: 1 passed, 1 total
Tests: 10996 passed, 10996 total
Snapshots: 0 total
Time: 2.089 s
Ran all test suites.

@0xkr3p
0xkr3p merged commit 5e7b772 into master Sep 22, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant