gami-labs: migrate WBTC vault to T3tris/Robinhood, add Midas turtlePST - #2842
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughGami Labs adds Midas and Robinhood Chain vault metadata, retrieves Midas share pricing through multicall, calculates TVL and APY, updates Stellar symbols, and isolates failures across source-specific processing paths. ChangesGami vault processing
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant apy
participant processMidas
participant Multicall
participant MidasVault
apy->>processMidas: process Midas vaults
processMidas->>Multicall: request share data and price feeds
Multicall->>MidasVault: read vault contract values
MidasVault-->>processMidas: return supply, decimals, symbol, and prices
processMidas-->>apy: return TVL and APY results
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The gami-labs adapter exports pools: Test Suites: 1 passed, 1 total |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/adaptors/gami-labs/index.js`:
- Line 317: Remove the self-referential underlyingTokens entry from the vault
metadata constructed around the underlyingTokens field. Do not emit v.address as
an underlying token for this directly priced multi-asset vault; omit the field
unless the actual underlying asset address(es) are available.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 51bdd41b-f4dc-4f16-8794-da9427cdbdee
📒 Files selected for processing (1)
src/adaptors/gami-labs/index.js
0xkr3p
reviewed
Jul 27, 2026
| apyBase, | ||
| apyBase7d, | ||
| pricePerShare: priceUsd, | ||
| underlyingTokens: [v.address.toLowerCase()], |
Contributor
There was a problem hiding this comment.
would underlying be usdc here rather than receipt token?
Contributor
Author
There was a problem hiding this comment.
USDC, fixed. Thanks for flagging
0xkr3p
reviewed
Jul 27, 2026
| // ROBINHOOD CHAIN — T3tris (migrated Gami WBTC vault; standard ERC-4626). | ||
| // Underlying WBTC on robinhoodchain is not yet priced by the DefiLlama price API, so this | ||
| // pool is omitted until a price is available (processChain drops entries with no price). | ||
| { sdkChain: 'robinhoodchain', address: '0xd5c6c79692715145098a65d1eb1f2a10c524f8e8', name: 'Gami WBTC', url: 'https://gamilabs.io/vaults/4663/0xd5c6c79692715145098a65d1eb1f2a10c524f8e8' }, |
Contributor
There was a problem hiding this comment.
robinhoodchain will not be recognised, in the formatChain helper, I believe we have robinhood, are you able to add robinhoodchain to the existing formatChain helper?
Contributor
Author
There was a problem hiding this comment.
Were first doing a fix on this on the Adapter PR as robinhood was not in the formatChain helper, I believe.
Just fixed it.
Thanks for flagging
0xkr3p
reviewed
Jul 27, 2026
0xkr3p
left a comment
0xkr3p
left a comment
Contributor
There was a problem hiding this comment.
hi @marien-gami, thanks for the PR a couple of comments to resolve before we can proceed
Contributor
Author
Thanks @0xkr3p, all comments should be resolved. |
|
The gami-labs adapter exports pools: Test Suites: 1 passed, 1 total |
Contributor
Author
Just added some fixes to the Receipt of Stellar vaults. Again, thanks! Have a great day! |
|
The gami-labs adapter exports pools: Test Suites: 1 passed, 1 total |
0xkr3p
approved these changes
Jul 27, 2026
0xkr3p
left a comment
0xkr3p
left a comment
Contributor
There was a problem hiding this comment.
thanks for the fast changes @marien-gami
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Bug Fixes