Repository navigation
Fix BCRYPT_PROVIDER_HANDLE access violation in CNG.pkg - #3
Merged
DataFlex-dev merged 1 commit intoAug 7, 2026
Conversation
BCryptDuplicateHash and BCryptDuplicateKey fetched BCRYPT_PROVIDER_HANDLE via BCryptNamedUIntegerPropertyValue, which only accepts 4-byte values. BCRYPT_PROVIDER_HANDLE is a native Handle, 8 bytes on x64, so the size check silently returned 0 and the next BCryptGetProperty call dereferenced a null handle. Both call sites now fetch the handle via raw BCryptNamedPropertyValue and copy it in only when the returned size matches SizeOfType(Handle). BCryptGetProperty's blanket 8-to-4 truncation is removed since it was corrupting the newly fetched 8-byte handle. The same tolerance is re-added scoped to BCryptNamedUIntegerPropertyValue, the one caller that legitimately wants 4 bytes. NCryptNamedUIntegerPropertyValue gets the same tolerance for symmetry, though it has no current callers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BCryptDuplicateHashandBCryptDuplicateKeyfetchedBCRYPT_PROVIDER_HANDLEviaBCryptNamedUIntegerPropertyValue, which only accepts 4-byte values.BCRYPT_PROVIDER_HANDLEis a native Handle, 8 bytes on x64, so the size check silently returned 0 and the nextBCryptGetPropertycall dereferenced a null handle.Both call sites now fetch the handle via raw
BCryptNamedPropertyValueand copy it in only when the returned size matches SizeOfType(Handle).BCryptGetProperty's blanket 8-to-4 truncation is removed since it was corrupting the newly fetched 8-byte handle. The same tolerance is re-added scoped toBCryptNamedUIntegerPropertyValue, the one caller that legitimately wants 4 bytes.NCryptNamedUIntegerPropertyValuegets the same tolerance for symmetry, though it has no current callers.