Skip to content

Fix regression for short lived processes - #251

Merged
r1viollet merged 3 commits into
mainfrom
r1viollet/fix_collatz
May 10, 2023
Merged

Fix regression for short lived processes#251
r1viollet merged 3 commits into
mainfrom
r1viollet/fix_collatz

Conversation

@r1viollet

Copy link
Copy Markdown
Collaborator

What does this PR do?

This is a quick fix that consists in refreshing the path for files to the last know location. A more long term fix would consist in finding the absolute path across containers.

Motivation

Reliability environment caught this regression.

This is a quick fix that consists in refreshing the path for files to the last know location.
A more long term fix would consist in finding the absolute path across containers.
@r1viollet
r1viollet requested review from nsavoire and sanchda as code owners May 9, 2023 14:54
Comment thread include/device_utils.hpp Outdated

@sanchda sanchda left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread test/dwfl_module-ut.cc Outdated
Comment thread test/dwfl_module-ut.cc Outdated
sanchda
sanchda previously approved these changes May 10, 2023

@sanchda sanchda left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nsavoire
nsavoire previously approved these changes May 10, 2023
- Revert accidental removal of unit test in cmake file
- Fix PR # 251 comments
@r1viollet
r1viollet dismissed stale reviews from nsavoire and sanchda via e00e16c May 10, 2023 13:04
@r1viollet
r1viollet merged commit 2912706 into main May 10, 2023
r1viollet added a commit that referenced this pull request May 17, 2023
* Fix regression for short lived processes

This is a quick fix that consists in refreshing the path for files to the last know location.
A more long term fix would consist in finding the absolute path across containers.
@r1viollet
r1viollet deleted the r1viollet/fix_collatz branch September 4, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants