Update record detection for fixed JDK by jpbempel · Pull Request #12031 · DataDog/dd-trace-java

jpbempel · 2026-07-22T12:12:44Z

What Does This Do

JDK 25.0.4 fixes the Record with type annotation bug (JDK-8376185) so we are updating the detection to filter out for this JDK version and onward

Motivation

Additional Notes

Contributor Checklist

Format the title according to the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any other useful labels
Avoid using close, fix, or any linking keywords when referencing an issue
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, migration, or deletion
Update public documentation with any new configuration flags or behaviors
Once approved, use merge queue to merge the PR

Jira ticket: [PROJ-IDENT]

JDK 25.0.4 fixes the Record with type annotation bug (JDK-8376185) so we are updating the detection to filter out for this JDK version and onward

dd-octo-sts · 2026-07-22T12:12:57Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: aaf49a6e76

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-07-22T12:17:42Z

+  private static final boolean JAVA_AT_LEAST_25_0_4 =
+      JavaVirtualMachine.isJavaVersionAtLeast(25, 0, 4);


Gate the workaround by each JDK feature line

On JDK 26.0.1 this evaluates true because the major version is greater than 25, but JDK-8376185 is listed as fixed in the JDK 26.0.2 update, not 26.0.1 (Oracle release notes). That means both record-type-annotation safety checks are bypassed on unfixed JDK 26 builds, so a probe on a record with TYPE_USE annotations can be instrumented/retransformed again and re-expose the NoSuchFieldError/JVM-corruption path this guard is meant to avoid. Please make this a per-feature-line check, e.g. 25 >= 25.0.4 and 26 >= 26.0.2, instead of a single lower bound.

Useful? React with 👍 / 👎.

True, but can ask to upgrade. so acceptable and marginal for JDK 26

datadog-official

More details

Version comparison logic is correct across all edge cases: isAtLeast(25, 0, 4) returns false for JDK 25.0.0 GA ("25" parses to 25.0.0), false for "25-ea" and 25.0.3, and true for 25.0.4, 25.0.4+build, 25.1.x, and any major ≥ 26 — the guard condition !JAVA_AT_LEAST_16 || JAVA_AT_LEAST_25_0_4 correctly applies the workaround on JDK 16–25.0.3 and skips it everywhere else.

Was this helpful? React 👍 or 👎

_{📊 Validated against 26 scenarios · Open Bits AI session}

_{🤖 Datadog Autotest · Commit aaf49a6 · What is Autotest? · Any feedback? Reach out in #autotest}

datadog-official · 2026-07-22T12:18:55Z

View session in Datadog

Bits Code status: ✅ Done

Comment @DataDog to request changes

pr-commenter · 2026-07-22T12:28:29Z

Debugger benchmarks

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
ci_job_date	1784722623	1784722969
end_time	2026-07-22T12:18:29	2026-07-22T12:24:14
git_branch	master	jpbempel/update-record-typeann-detection
git_commit_sha	`c7901a5`	`aaf49a6`
start_time	2026-07-22T12:17:04	2026-07-22T12:22:50

See matching parameters

	Baseline	Candidate
ci_job_id	1882332451	1882332451
ci_pipeline_id	126214162	126214162
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date	1784722044	1784722044

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 5 unstable metrics.

See unchanged results

scenario	Δ mean agg_http_req_duration_min	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p75	Δ mean agg_http_req_duration_p99	Δ mean throughput
scenario:noprobe	unstable [-16.505µs; +25.971µs] or [-5.698%; +8.965%]	unstable [-27.375µs; +38.733µs] or [-8.249%; +11.671%]	unstable [-37.759µs; +50.850µs] or [-10.876%; +14.647%]	unstable [-318.398µs; -106.507µs] or [-22.324%; -7.468%]	same
scenario:basic	same	same	same	unstable [-299.917µs; -28.167µs] or [-24.044%; -2.258%]	same
scenario:loop	unsure [-7.583µs; -1.362µs] or [-0.085%; -0.015%]	unsure [+2.556µs; +14.820µs] or [+0.028%; +0.165%]	same	same	same

Request duration reports for reports

gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (331.875 µs) : 305, 359
.   : milestone, 332,
basic (298.478 µs) : 292, 305
.   : milestone, 298,
loop (8.982 ms) : 8976, 8988
.   : milestone, 8982,
section candidate
noprobe (337.554 µs) : 302, 373
.   : milestone, 338,
basic (296.31 µs) : 289, 304
.   : milestone, 296,
loop (8.991 ms) : 8985, 8996
.   : milestone, 8991,

baseline results

Scenario	Request median duration [CI 0.99]
noprobe	331.875 µs [304.675 µs, 359.076 µs]
basic	298.478 µs [291.559 µs, 305.398 µs]
loop	8.982 ms [8.976 ms, 8.988 ms]

candidate results

Scenario	Request median duration [CI 0.99]
noprobe	337.554 µs [302.405 µs, 372.703 µs]
basic	296.31 µs [288.96 µs, 303.66 µs]
loop	8.991 ms [8.985 ms, 8.996 ms]

dd-octo-sts · 2026-07-22T12:33:50Z

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite	Status
Startup	🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results

Scenario	Candidate	master	Δ (95% CI of mean)
startup:insecure-bank:iast:Agent	14.00 s	13.99 s	[-0.6%; +0.8%] (no difference)
startup:insecure-bank:tracing:Agent	12.95 s	13.04 s	[-1.5%; +0.1%] (no difference)
startup:petclinic:appsec:Agent	16.46 s	16.66 s	[-5.6%; +3.1%] (no difference)
startup:petclinic:iast:Agent	16.75 s	16.51 s	[-2.9%; +5.9%] (no difference)
startup:petclinic:profiling:Agent	16.66 s	16.29 s	[-2.1%; +6.7%] (no difference)
startup:petclinic:sca:Agent	16.84 s	16.43 s	[-1.9%; +6.9%] (no difference)
startup:petclinic:tracing:Agent	15.63 s	16.01 s	[-6.4%; +1.8%] (no difference)

Commit: aaf49a6e · CI Pipeline · Benchmarking Platform UI

Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

dd-octo-sts · 2026-07-22T16:03:11Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-07-22T16:03:16Z

View all feedbacks in Devflow UI.

2026-07-22 16:03:15 UTC ℹ️ Start processing command /merge

2026-07-22 16:03:21 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).

2026-07-22 18:00:24 UTC ℹ️ MergeQueue: This merge request was merged

Update record detection for fixed JDK

aaf49a6

JDK 25.0.4 fixes the Record with type annotation bug (JDK-8376185) so we are updating the detection to filter out for this JDK version and onward

jpbempel requested a review from a team as a code owner July 22, 2026 12:12

jpbempel requested review from andreimatei and removed request for a team July 22, 2026 12:12

jpbempel added comp: debugger Dynamic Instrumentation type: bug fix Bug fix labels Jul 22, 2026

chatgpt-codex-connector Bot reviewed Jul 22, 2026

View reviewed changes

datadog-official Bot reviewed Jul 22, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

jpbempel requested review from ojung and removed request for andreimatei July 22, 2026 15:21

bric3 approved these changes Jul 22, 2026

View reviewed changes

jpbempel added this pull request to the merge queue Jul 22, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 22, 2026

gh-worker-dd-mergequeue-cf854d Bot merged commit 63e8a26 into master Jul 22, 2026
599 of 603 checks passed

gh-worker-dd-mergequeue-cf854d Bot deleted the jpbempel/update-record-typeann-detection branch July 22, 2026 18:00

github-actions Bot added this to the 1.65.0 milestone Jul 22, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update record detection for fixed JDK#12031

Update record detection for fixed JDK#12031
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
jpbempel/update-record-typeann-detection

jpbempel commented Jul 22, 2026

Uh oh!

dd-octo-sts Bot commented Jul 22, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Jul 22, 2026

Uh oh!

jpbempel Jul 22, 2026

Uh oh!

datadog-official Bot left a comment

Uh oh!

datadog-official Bot commented Jul 22, 2026 •

edited by datadog-datadog-prod-us1-2 Bot

Loading

Uh oh!

This comment has been minimized.

pr-commenter Bot commented Jul 22, 2026

Uh oh!

dd-octo-sts Bot commented Jul 22, 2026

Uh oh!

dd-octo-sts Bot commented Jul 22, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Jul 22, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		private static final boolean JAVA_AT_LEAST_25_0_4 =
		JavaVirtualMachine.isJavaVersionAtLeast(25, 0, 4);

Uh oh!

Conversation

jpbempel commented Jul 22, 2026

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

dd-octo-sts Bot commented Jul 22, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jul 22, 2026

Choose a reason for hiding this comment

Uh oh!

jpbempel Jul 22, 2026

Choose a reason for hiding this comment

Uh oh!

datadog-official Bot left a comment

Choose a reason for hiding this comment

Uh oh!

datadog-official Bot commented Jul 22, 2026 • edited by datadog-datadog-prod-us1-2 Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

pr-commenter Bot commented Jul 22, 2026

Debugger benchmarks

Parameters

Summary

Uh oh!

dd-octo-sts Bot commented Jul 22, 2026

🟢 Java Benchmark SLOs — All performance SLOs passed

Uh oh!

dd-octo-sts Bot commented Jul 22, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

datadog-official Bot commented Jul 22, 2026 •

edited by datadog-datadog-prod-us1-2 Bot

Loading

gh-worker-devflow-routing-ef8351 Bot commented Jul 22, 2026 •

edited

Loading